-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db: reformat Metrics.String()
output
#1473
Labels
Comments
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 13, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Fixes cockroachdb#1473.
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 15, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Fixes cockroachdb#1473.
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 15, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Fixes cockroachdb#1473.
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 15, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Fixes cockroachdb#1473.
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 15, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Fixes cockroachdb#1473.
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 16, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Fixes cockroachdb#1473.
RaduBerinde
added a commit
to RaduBerinde/pebble
that referenced
this issue
Jul 18, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Release note: Pebble metrics formatting improvements; tools that parse these logs might need updating. Fixes cockroachdb#1473.
RaduBerinde
added a commit
that referenced
this issue
Jul 18, 2023
This change improves the formatting of the Pebble metrics: - we no longer try to artificially fit non-tabular information in a single table - all byte figures end in B/KB/MB/etc - counts and corresponding sizes are grouped together - flushable ingests information moved under ingestions These metrics are periodically logged and can be obtained through the db console as well. Release note: Pebble metrics formatting improvements; tools that parse these logs might need updating. Fixes #1473.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Metrics.String()
output is often used in debugging storage issues. As we've accumulated more statistics that are not per-level, each has been appended as an independent line with descriptive annotations like(size == estimated-debt, score = in-progress-bytes, in = num-in-progress)
.With a little thought and elbow grease, I think these could be restructured to be a little more legible and avoid the excess vertical height.
The text was updated successfully, but these errors were encountered: