-
Notifications
You must be signed in to change notification settings - Fork 476
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
*: remove mergingIter.elideRangeTombstone
Simplify the mergingIter range tombstone elision logic to not need to know whether it's part of an Iterator or a compaction iterator. Previously if elideRangeTombstone was true, the mergingIter was part of an `Iterator` and we'd skip any RANGEDEL keys coming from child iterators, which really only happened to be synthetic bound keys or ignorable bound keys (set as such in i.boundaryContext). For compaction iterators, we'd continue to surface all RANGEDELs observed (and elideRangeTombstone was false). Now, rangedels from child iterators that are `!isIgnorableBoundaryKey` are surfaced by the merging iter, and the last remaining case where we wanted to surface a key but `isIgnorableBoundaryKey=false` was in skipEmptyFileBackward and that has also been changed to isIgnorableBoundaryKey=true. This removes the need for elideRangeTombstone so that has been cleared up, and any tests that relied on elideRangeTombstone have been updated.
- Loading branch information
Showing
7 changed files
with
44 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.