Skip to content

Commit

Permalink
sstable: don't embed fields in category stats
Browse files Browse the repository at this point in the history
Embedding here is not necessary and it causes the types to inherit
methods like `SafeFormat` which at best are incomplete.
  • Loading branch information
RaduBerinde committed Jun 6, 2024
1 parent 8fb4665 commit 47da75f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions sstable/category_stats.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ func StringToQoSForTesting(s string) QoSLevel {

// CategoryAndQoS specifies both the Category and the QoSLevel.
type CategoryAndQoS struct {
Category
QoSLevel
Category Category
QoSLevel QoSLevel
}

// CategoryStats provides stats about a category of reads.
Expand All @@ -91,9 +91,9 @@ func (s *CategoryStats) aggregate(a CategoryStats) {

// CategoryStatsAggregate is the aggregate for the given category.
type CategoryStatsAggregate struct {
Category
QoSLevel
CategoryStats
Category Category
QoSLevel QoSLevel
CategoryStats CategoryStats
}

type categoryStatsWithMu struct {
Expand Down

0 comments on commit 47da75f

Please sign in to comment.