Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

block_writer: update for breaking change in satori/go.uuid API #112

Merged
merged 1 commit into from
May 24, 2018

Conversation

pib
Copy link
Contributor

@pib pib commented May 23, 2018

As mentioned at satori/go.uuid#66, the satori/go.uuid API changed, so the call to uuid.NewV4 needs to be wrapped in uuid.Must.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis
Copy link
Contributor

@pib Thanks for the fix. This binary isn't under active use any more. We should probably just delete it, but might as well merge this PR until that is done.

@petermattis petermattis merged commit ca52c94 into cockroachdb:master May 24, 2018
@pib pib deleted the fix_uuid branch June 7, 2018 00:59
@pib
Copy link
Contributor Author

pib commented Jun 7, 2018

@petermattis I came upon it because it is mentioned in the docs at https://www.cockroachlabs.com/docs/stable/demo-automatic-rebalancing.html, so y'all may want to update that page as well.

@petermattis
Copy link
Contributor

@pib Thanks for the docs pointer. We'll get that fixed.

@bdarnell
Copy link
Contributor

bdarnell commented Jun 7, 2018

Also, as discussed in cockroachdb/cockroach#26332, the API change also introduced a severe bug (at least on macos) that has not been fixed (the maintainer has been unresponsive), so any users of go.uuid should pin to an older version or switch to a different package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants