Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct aggregate functions in 19.2 docs #8476

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Correct aggregate functions in 19.2 docs #8476

merged 1 commit into from
Sep 28, 2020

Conversation

jseldess
Copy link
Contributor

Fixes #7236.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0e098e6ab69197ec5cd33b81172e490939911db6/

ericharmeling
ericharmeling approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@ericharmeling
Copy link
Contributor

@jseldess

I think this might resolve #6179 as well.

@jseldess
Copy link
Contributor Author

Thanks @ericharmeling.

@jseldess jseldess merged commit 1e1063e into master Sep 28, 2020
@jseldess jseldess deleted the function-doc-fix branch September 28, 2020 18:34
@jseldess jseldess mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharmeling ericharmeling ericharmeling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window functions appear under "Aggregate functions" in 19.2 docs
3 participants
@jseldess @cockroach-teamcity @ericharmeling