Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20.1 known limitations #7118

Merged
merged 1 commit into from
Apr 18, 2020
Merged

20.1 known limitations #7118

merged 1 commit into from
Apr 18, 2020

Conversation

jseldess
Copy link
Contributor

Add new limitations and remove resolved limitations.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/020348279dbc4d5d6fcbd8e24220be2438366f7b/

Edited pages:

@jseldess jseldess force-pushed the 20.1-known-limitations branch from 0203482 to 127fa47 Compare April 13, 2020 13:36
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/127fa476fe1b6c0f282340ce3c8f7474986051bd/

Edited pages:

@awoods187
Copy link
Contributor

@lucy-zhang @jordanlewis and @RaduBerinde are there any other known limitations that can be lifted for 20.1?

This was referenced Apr 16, 2020
Open
Closed
@jseldess jseldess force-pushed the 20.1-known-limitations branch from 127fa47 to 394a624 Compare April 16, 2020 16:04
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/394a624910d6da406bba6e60cc09f8fc32d90843/

Edited pages:

@jseldess jseldess force-pushed the 20.1-known-limitations branch from 394a624 to ce25c3f Compare April 16, 2020 17:44
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ce25c3ff0e96458157560fa5c0c484fa97ae63c6/

Edited pages:

@jseldess jseldess changed the title [WIP] 20.1 known limitations 20.1 known limitations Apr 16, 2020
@jseldess
Copy link
Contributor Author

v20.1/known-limitations.md, line 60 at r1 (raw file):

[Tracking Github Issue](https://github.com/cockroachdb/cockroach/issues/43177)

### Concurrent SQL shells overwrite each other's history

@knz, PTAL.

@jseldess
Copy link
Contributor Author

v20.1/known-limitations.md, line 78 at r1 (raw file):

## Unresolved limitations

### Enterprise `BACKUP` does not capture database/table/column comments

@knz, PTAL.

@jseldess
Copy link
Contributor Author

v20.1/known-limitations.md, line 11 at r1 (raw file):

## New limitations

### `ROLLBACK TO SAVEPOINT` in high-priority transactions containing DDL

@knz, PTAL.

@jseldess
Copy link
Contributor Author

v20.1/known-limitations.md, line 28 at r1 (raw file):

[Tracking Github Issue](https://github.com/cockroachdb/cockroach/issues/46414)

### Column name from an outer column inside a subquery differs from PostgreSQL

@RaduBerinde, PTAL.

@jseldess
Copy link
Contributor Author

v20.1/known-limitations.md, line 54 at r1 (raw file):

[Tracking Github Issue](https://github.com/cockroachdb/cockroach/issues/46563)

### Privileges required to access to certain virtual tables differs from PostgreSQL

@knz, PTAL.

@jseldess jseldess force-pushed the 20.1-known-limitations branch from ce25c3f to 3d68a98 Compare April 16, 2020 21:12
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3d68a98f51993da3f21c30fb7840c50bb44c3edf/

Edited pages:

@RaduBerinde
Copy link
Member

v20.1/known-limitations.md, line 28 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

@RaduBerinde, PTAL.

Looks great, thanks!

@jseldess jseldess force-pushed the 20.1-known-limitations branch from 3d68a98 to 61e089a Compare April 17, 2020 19:11
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/61e089a2254a494017cd8eee4b994c3801c98faa/

Edited pages:

knz
knz reviewed Apr 18, 2020
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess)

v19.1/known-limitations.md, line 15 at r2 (raw file):

The [`COMMENT ON`](comment-on.html) statement associates comments to databases, tables, or columns. However, the internal table (`system.comments`) in which these comments are stored is not captured by enterprise [`BACKUP`](backup.html).

As a workaround, use the [`cockroach dump`](sql-dump.html) command, which emits `COMMENT ON` statements alongside `CREATE` statements.

I would recommend using the "schema only" for dump alongside BACKUP

v20.1/known-limitations.md, line 11 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

@knz, PTAL.

that's good thanks

v20.1/known-limitations.md, line 54 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

@knz, PTAL.

lgtm

v20.1/known-limitations.md, line 60 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

@knz, PTAL.

lgtm

v20.1/known-limitations.md, line 78 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

@knz, PTAL.

see my comment above

@jseldess jseldess force-pushed the 20.1-known-limitations branch from 61e089a to 4d65418 Compare April 18, 2020 19:40
jseldess
jseldess commented Apr 18, 2020
View reviewed changes
Copy link
Contributor Author

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess, @knz, and @RaduBerinde)

v19.1/known-limitations.md, line 15 at r2 (raw file):

Previously, knz (kena) wrote…

I would recommend using the "schema only" for dump alongside BACKUP

Done.

v20.1/known-limitations.md, line 11 at r1 (raw file):

Previously, knz (kena) wrote…

that's good thanks

Thanks!

v20.1/known-limitations.md, line 28 at r1 (raw file):

Previously, RaduBerinde wrote…

Looks great, thanks!

Thanks!

v20.1/known-limitations.md, line 54 at r1 (raw file):

Previously, knz (kena) wrote…

lgtm

Thanks!

v20.1/known-limitations.md, line 60 at r1 (raw file):

Previously, knz (kena) wrote…

lgtm

Thanks!

v20.1/known-limitations.md, line 78 at r1 (raw file):

Previously, knz (kena) wrote…

see my comment above

Done.

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4d65418de8f0d4e334a7a55e52f86bc06c28fff8/

Edited pages:

@jseldess jseldess force-pushed the 20.1-known-limitations branch from 4d65418 to 3053645 Compare April 18, 2020 20:47
@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3053645dcf7d106e037037f857542b20ea8bba2b/

Edited pages:

@jseldess jseldess merged commit 8402a51 into master Apr 18, 2020
@jseldess jseldess deleted the 20.1-known-limitations branch April 18, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jseldess @cockroach-teamcity @awoods187 @RaduBerinde @knz