Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v19.2.2 release notes #6164

Merged
merged 1 commit into from
Dec 17, 2019
Merged

v19.2.2 release notes #6164

merged 1 commit into from
Dec 17, 2019

Conversation

ericharmeling
Copy link
Contributor

No description provided.

@ericharmeling ericharmeling requested a review from dt December 16, 2019 20:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/51e65876815252883858746ffd007a7d2937ada5/

Edited pages:

dt
dt reviewed Dec 16, 2019
View reviewed changes
Copy link
Member

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing the last couple backports added last week -- the last PR should be cockroachdb/cockroach#43095, right?

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e9f9ecce24effd18ce6293a6ec5a2e57eb43efe9/

Edited pages:

@ericharmeling
Copy link
Contributor Author

@dt

I think this is missing the last couple backports added last week -- the last PR should be cockroachdb/cockroach#43095, right?

We generate release notes with scripts/release-notes.py, which doesn't pick up commits with "Release note: None" in the message. I generated and then edited this yesterday, so it should include every merged commit without "Release note: None" in the message.

The message for cockroachdb/cockroach#43095 includes "Release note: None". I can add one for that PR, if we want to consider the change "user-facing".

Any other backports need release notes?

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3a20ebe46dc2ae1ae87ac7f607c49ccbdc713daf/

Edited pages:

@dt
Copy link
Member

dt commented Dec 17, 2019

Ah, okay, I was just eye-balling the list of PRs at the bottom and thought it had missed the restarted release. LGTM.

@ericharmeling ericharmeling mentioned this pull request Dec 17, 2019
Merged
rmloveland
rmloveland approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one broken link and a suggestion to reorder phrasing of the "prevent corruption from spreading" item for clarity. All else are nits.

releases/v19.2.2.md Outdated
- Improved the consistency checker's log output. [#42149][#42149]
- Nodes that have been terminated as the result of a failed consistency check now refuse to restart, making it more likely that the operator notices that there is a persistent issue in a timely manner. [#42149][#42149]
- Client usernames can now be defined to start with a digit; in particular, all-digit usernames are now permitted. [#42989][#42989]
- When the replicas within a range are corrupted, outliers are now terminated. Previously, the leaseholder replica would terminate, regardless of which replicas disagreed with each other. This is expected to curb the spreading of corrupted data better than the previous approach. [#42149][#42149]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~Might be worth rephrasing to say what this is doing up front rather than at the end, e.g., "Curb the spread of corrupted data by terminating outliers when the replicas within a range are corrupted. Previously, ... "

releases/v19.2.2.md Outdated

### Enterprise edition changes

- `RESTORE` now supports the restoration of empty databases. [#42733][#42733]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~Nit: Mention of RESTORE could be a link?

releases/v19.2.2.md Outdated

### Command-line changes

- `--global` flag is now marked as hidden. [#41938][41938]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~Issue link is busted (target also needs '#').

releases/v19.2.2.md Outdated

### Bug fixes

- The [`TIMESTAMP`](../v19.2/timestamp.html) data type is now fully supported by the vectorized engine. Previously, an "unsupported type" error might occur. [#42576][#42576]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~Nit: first mention of vectorized engine could be a link to relevant docs.

ericharmeling
ericharmeling commented Dec 17, 2019
View reviewed changes
Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR Rich!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rmloveland)

releases/v19.2.2.md, line 45 at r1 (raw file):

Previously, rmloveland (Rich Loveland) wrote…

~Might be worth rephrasing to say what this is doing up front rather than at the end, e.g., "Curb the spread of corrupted data by terminating outliers when the replicas within a range are corrupted. Previously, ... "

Fixed.

releases/v19.2.2.md, line 49 at r1 (raw file):

Previously, rmloveland (Rich Loveland) wrote…

~Nit: Mention of RESTORE could be a link?

Fixed.

releases/v19.2.2.md, line 61 at r1 (raw file):

Previously, rmloveland (Rich Loveland) wrote…

~Issue link is busted (target also needs '#').

Done.

releases/v19.2.2.md, line 65 at r1 (raw file):

Previously, rmloveland (Rich Loveland) wrote…

~Nit: first mention of vectorized engine could be a link to relevant docs.

Done.

@cockroach-teamcity
Copy link
Member

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0478b8802b9987089c28c447214cce4ea55a4407/

Edited pages:

@ericharmeling ericharmeling merged commit bbd5e64 into master Dec 17, 2019
@ericharmeling ericharmeling deleted the v19.2.2-release-notes branch December 17, 2019 21:40
@ericharmeling ericharmeling mentioned this pull request Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt dt dt left review comments

@rmloveland rmloveland rmloveland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericharmeling @cockroach-teamcity @dt @rmloveland