Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions related to http-addr #447

Merged
merged 2 commits into from
Jul 12, 2016
Merged

Revisions related to http-addr #447

merged 2 commits into from
Jul 12, 2016

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented Jul 12, 2016

This PR contains revisions/clarifications around the new --http-addr flag. It also removes instructions about ssh tunneling, as requested by @tamird here.

Also, this PR tries to clarify what --host defaults to, depending on scenario. Fixes #446

HTTP version available here: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b379df2ae3f552cff5fea8bbb13a0d3178206c35

@tamird, @glycerine, PTAL


This change is Reviewable

@glycerine
Copy link
Contributor

Obviously I felt that the ssh tunnel part was essential, else I would not have included it.

The only benefit obtained from removing the ssh hints is to make getting started either insecure or much harder. Hence that threatens usability and adoption.

@tamird
Copy link
Contributor

tamird commented Jul 12, 2016

:lgtm:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


manual-deployment.md, line 227 [r1] (raw file):

<img src="images/admin_ui.png" alt="CockroachDB Admin UI" style="border:1px solid #eee;max-width:100%" />

{{site.data.alerts.callout_info}}In cases where you set <code>--http-addr</code> to <code>localhost</code> and need to access the Admin UI from a machine separate from the cluster, you can use SSH to tunnel from the machine to a node.{{site.data.alerts.end}}  

s/from the cluster//


Comments from Reviewable

@jseldess
Copy link
Contributor Author

Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


manual-deployment.md, line 227 [r1] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

s/from the cluster//

Done.

Comments from Reviewable

@jseldess
Copy link
Contributor Author

@glycerine, after talking with @tamird and @bdarnell about this, the consensus was to leave explicit ssh tunnel instructions out since we want our docs to focus on cockroachdb and not general devops, and since we're not production ready yet anyway. Also, we do plan on improving UI security. That said, if you think we need another note somewhere suggesting tunneling, please let me know.


Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@jseldess jseldess merged commit 6fea601 into gh-pages Jul 12, 2016
@jseldess jseldess deleted the http-addr-tweaks branch July 12, 2016 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants