-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for column families #422
Conversation
@paperstreet, I don't think the story is right yet. Once we define column families by default, I'm inclined to reveal more about that in |
I think the story is pretty good as you have it. Here's my initial thoughts. I'll do a followup pass and think of what you're missing Review status: 0 of 9 files reviewed at latest revision, 4 unresolved discussions. column-families.md, line 9 [r1] (raw file):
This is only true if you use the feature, which I feel is an important distinction. If you've upgraded and haven't manually assigned families (even if you've created new tables), you can downgrade column-families.md, line 15 [r1] (raw file):
single key-value pair per family column-families.md, line 25 [r1] (raw file):
I'm not really sure what we're contrasting to. If some competitor, which one? If previous versions of cockroach, this is not technically true, because we'd have an extra +1 per row for a total of 30 column-families.md, line 77 [r1] (raw file):
optimal is far too strong a promise for what is coming : - ) maybe reasonable Comments from Reviewable |
Okay this what I could think of that's missing dt mentions that the "Storage Parameters" section of https://www.postgresql.org/docs/current/static/sql-createtable.html is a good example of the level of emphasis we should be placing on the manual configuration of these. Note that it's fairly buried. Review status: 0 of 9 files reviewed at latest revision, 6 unresolved discussions. column-families.md, line 7 [r1] (raw file):
The even bigger advantage is that it reduces the number of keys you're changing during inserts/updates/deletes, which has all kinds of performance benefits. Less data over the wire, smaller raft and rocksdb logs, fewer write intents to conflict. Basically, this is even a bigger deal for a 3 node setup than a single node. Maybe " column-families.md, line 52 [r1] (raw file):
I don't think it's clear anywhere that you can specify more than one family. You might want to do this if you have one small column that gets updated a lot and one big column that doesn't. Because of the way families work, if you put both in one family, the big one will have to be rewritten every time the little one is updated. This general issue is why we won't simply always use one family Important to emphasize: You should always use as few column families as reasonable. Our upcoming heuristic tries to group "bounded-size" columns (INT, TIMESTAMP, STRING(100), etc). Unfortunately, if the user specifies STRING, DECIMAL, BYTES without a max size, we have to be pessimistic and give it its own group. This is the major reason that users should expect to tell cockroach about family assignments. If you know that your STRING (or DECIMAL or BYTES) field will usually be small, but don't want the hard bound on it, then you can use this feature to force them together. Comments from Reviewable |
Review status: 0 of 9 files reviewed at latest revision, 6 unresolved discussions. column-families.md, line 9 [r1] (raw file):
|
Review status: 0 of 9 files reviewed at latest revision, 6 unresolved discussions. column-families.md, line 7 [r1] (raw file):
|
just a last couple notes Review status: 0 of 9 files reviewed at latest revision, 8 unresolved discussions. column-families.md, line 52 [r1] (raw file):
|
Review status: 0 of 9 files reviewed at latest revision, 8 unresolved discussions. column-families.md, line 52 [r1] (raw file):
|
Review status: 0 of 9 files reviewed at latest revision, 8 unresolved discussions. Comments from Reviewable |
create-table.md
.column-families.md
.HTML version available here: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6545def8fd90b97db710c935cc7322955af9fa4c/
Fixes #423
This change is