Update the documentation for UPSERT and INSERT #4215
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
v2.1/insert.md, line 661 at r1 (raw file):
~~~ ### Importing data with duplicates rows using `ON CONFLICT`
To be consistent with other example titles, change Importing to Import.
Also change duplicates to duplicate.
v2.1/upsert.md, line 18 at r1 (raw file):
- A single [multi-row `UPSERT`](#upsert-multiple-rows) statement is faster than multiple single-row `UPSERT` statements. Whenever possible, use multi-row `UPSERT` instead of multiple single-row `UPSERT` statements. - If the input data contains duplicates, see [Importing data with duplicate rows](#importing-data-with-duplicate-rows) below.
You'll need to update the link as well.
v2.1/upsert.md, line 22 at r1 (raw file):
## Required privileges The user must have the `INSERT`, `SELECT` and `UPDATE` [privileges](authorization.html#assign-privileges) on the table.
Unfortunately, @Amruta-Ranade hasn't yet ported the security doc changes from 2.2 to 2.1 yet, so this link is broken. Instead, please just use privileges.html, and Amruta will fix this when she handles the backporting.
v2.1/upsert.md, line 238 at r1 (raw file):
~~~ ### Importing data with duplicate rows
To be consistent with other example titles, change Importing to Import.
v2.2/insert.md, line 661 at r1 (raw file):
~~~ ### Importing data with duplicates rows using `ON CONFLICT`
To be consistent with other example titles, change Importing to Import.
Also change duplicates to duplicate.
v2.2/upsert.md, line 18 at r1 (raw file):
- A single [multi-row `UPSERT`](#upsert-multiple-rows) statement is faster than multiple single-row `UPSERT` statements. Whenever possible, use multi-row `UPSERT` instead of multiple single-row `UPSERT` statements. - If the input data contains duplicates, see [Importing data with duplicate rows](#importing-data-with-duplicate-rows) below.
Same as above.
v2.2/upsert.md, line 238 at r1 (raw file):
~~~ ### Importing data with duplicate rows
To be consistent with other example titles, change Importing to Import.
As was discussed with @andy-kimball.
knz
force-pushed
the
20181228-insert-upsert
branch
from
f1ccc15 to
bd3123c
Compare
There was a problem hiding this comment.
Reviewable status:
v2.1/insert.md, line 661 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
To be consistent with other example titles, change
ImportingtoImport.Also change
duplicatestoduplicate.
Done.
v2.1/upsert.md, line 18 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
You'll need to update the link as well.
Done.
v2.1/upsert.md, line 22 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Unfortunately, @Amruta-Ranade hasn't yet ported the security doc changes from 2.2 to 2.1 yet, so this link is broken. Instead, please just use
privileges.html, and Amruta will fix this when she handles the backporting.
Done.
v2.1/upsert.md, line 238 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
To be consistent with other example titles, change
ImportingtoImport.
Done.
v2.2/insert.md, line 661 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
To be consistent with other example titles, change
ImportingtoImport.Also change
duplicatestoduplicate.
Done.
v2.2/upsert.md, line 18 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Same as above.
Done.
v2.2/upsert.md, line 238 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
To be consistent with other example titles, change
ImportingtoImport.
Done.
|
thanks :) |
As was discussed with @andy-kimball.