-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Stop a Node' with more draining info #2671
Changes from 1 commit
ff04f3f
4275ac1
7bfe68d
3df0393
948ef35
eb14466
64e718f
14139e9
76a5622
6c72d46
d9d22a1
094d164
bb14e1b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ For information about permanently removing nodes to downsize a cluster or react | |
### How It Works | ||
|
||
- Cancels all current sessions without waiting. | ||
- Transfers all *range leases* and Raft leadership to other nodes. (1.1.6) | ||
- Transfers all *range leases* and Raft leadership to other nodes. | ||
- Gossips its draining state to the cluster so that no leases are transferred to the draining node. Note that this is a best effort that times out after the duration specified by the `???` cluster setting, so other nodes may not receive the gossip info in time. (1.1.6) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This still happens as of 1.1.6. In 1.1.5 and earlier, this part was broken. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for confirming. Do you know if there is a cluster setting for this in 1.1.6? None of the documented cluster settings for 1.1.6 look to be the one. And it wasn't clear from a quick |
||
- No new ranges are transferred to the draining node, to avoid a possible loss of quorum after the node shuts down. (1.1.5) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is true for all 1.1.x versions, as far as I'm aware. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! Again, leaving in but removing the version number. |
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: bold instead of italics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in bb14e1b