Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-9654 PR #118850 - server: enable continuous CPU profiler #18492

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Apr 19, 2024

Fix DOC-9654

(1) In automatic-cpu-profiler.md, (a) remove note and warnings, (b) update default values for server.cpu_profile.cpu_usage_combined_threshold and server.cpu_profile.interval, (c) removed recommended values column and section, (d) changed values in high-water mark threshold section to match default values, (e) removed mention to consult support.

rendered preview: Automatic CPU Profiler

…pdate default values for server.cpu_profile.cpu_usage_combined_threshold and server.cpu_profile.interval, (c) removed recommended values column and section, (d) changed values in high-water mark threshold section to match default values, (e) removed mention to consult support.
Copy link

Files changed:

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit a674bb4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/663127b4509bc9000862d8a2

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit a674bb4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/663127b436ebe300089b240c

Copy link

netlify bot commented Apr 19, 2024

Netlify Preview

Name Link
🔨 Latest commit a674bb4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/663127b4de502b0008742f67
😎 Deploy Preview https://deploy-preview-18492--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@aadityasondhi aadityasondhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the one comment.

src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
Copy link

@aadityasondhi aadityasondhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florence-crl florence-crl requested a review from taroface April 24, 2024 17:48
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for clarity

src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!

src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
@florence-crl florence-crl requested a review from taroface April 29, 2024 13:25
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have another phrasing suggestion now that I (hopefully) understand this setting more clearly. Approving but let me know if you want to discuss!

src/current/v24.1/automatic-cpu-profiler.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit cf21100 into main Apr 30, 2024
6 checks passed
@florence-crl florence-crl deleted the DOC-9654 branch April 30, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants