-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-9654 PR #118850 - server: enable continuous CPU profiler #18492
Conversation
…pdate default values for server.cpu_profile.cpu_usage_combined_threshold and server.cpu_profile.interval, (c) removed recommended values column and section, (d) changed values in high-water mark threshold section to match default values, (e) removed mention to consult support.
Files changed: |
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTRs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have another phrasing suggestion now that I (hopefully) understand this setting more clearly. Approving but let me know if you want to discuss!
Fix DOC-9654
(1) In automatic-cpu-profiler.md, (a) remove note and warnings, (b) update default values for server.cpu_profile.cpu_usage_combined_threshold and server.cpu_profile.interval, (c) removed recommended values column and section, (d) changed values in high-water mark threshold section to match default values, (e) removed mention to consult support.
rendered preview: Automatic CPU Profiler