-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managing sessions and queries #1828
Conversation
cc: @knz, @dianasaur323, and @nstewart, if you want to take a look as well. |
60d74b8
to
dcdbccb
Compare
Great, thank you. This is on my list of features to QA, so I'll let you know if I hit any issues. |
Actually, @nstewart and @dianasaur323, please hold off on your reviews until @itsbilal gets his in. Want to ensure everything's correct technically. Also need to integrate some changes from cockroachdb/cockroach#17579. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Save for the last_active_query
field in SHOW SESSIONS
(as you pointed out).
You may also wanna mention that you can do queries like:
CANCEL QUERY (SELECT query_id FROM [SHOW CLUSTER QUERIES] WHERE client_address = '192.168.0.72:56194'
AND username = 'mroach'
AND query = 'SELECT * FROM test.kv ORDER BY k');
Instead of running the SELECT/SHOW first and then copy/pasting the ID into the CANCEL statement.
TFTR, @itsbilal. Just expanded the I can't quite understand your suggestion about filtering above. I think part of your query got truncated? |
@jseldess The initial message got truncated but I edited it. Take another look? It's basically just the nesting of a SELECT inside the CANCEL QUERY. LGTM otherwise. It's your call on whether to mention the nested query example in the docs or not, but I'd argue it's a very useful one to have in there. |
bfbb23a
to
a5ef25a
Compare
Added your nested query example, @itsbilal. Thanks! Also added a dummy |
@nstewart, @dianasaur323, PTAL when you have time. |
a5ef25a
to
d03fd7d
Compare
Ping, @nstewart. |
d03fd7d
to
c6c7c83
Compare
@itsbilal, I ended up expanding this PR to cover |
c6c7c83
to
58430df
Compare
Might need to integrate changes from cockroachdb/cockroach#17739. |
This seems to imply that Also note that the spelling of |
58430df
to
fd31a6c
Compare
Thanks, @itsbilal. Made updates. |
Also update query performance troubleshooting page to link to new page, and remove details about query logging (for now).
fd31a6c
to
93b5eb7
Compare
I already ran through the docs, and things worked fine for me. Thanks Jesse.
On Mon, Aug 21, 2017 at 10:30 AM Jesse Seldess ***@***.***> wrote:
Ping, @nstewart <https://github.com/nstewart>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1828 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgDWI_Su9imvGNqVglBPh381RWdHo42ks5saZRpgaJpZM4O5TI3>
.
--
Diana Hsieh
[email protected]
407-690-9048
|
SHOW SESSIONS
SHOW QUERIES
CANCEL QUERY
Fixes #1562
Fixes #1572
Fixes #1571