Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick follow on 23.1.0 release notes #16976

Merged
merged 4 commits into from
May 15, 2023
Merged

Quick follow on 23.1.0 release notes #16976

merged 4 commits into from
May 15, 2023

Conversation

lnhsingh
Copy link
Contributor

Quick follow to #16951

@github-actions
Copy link

github-actions bot commented May 15, 2023

Files changed:

  • _includes/releases/v23.1/v23.1.0.md:
  • _includes/version-switcher.html:
    • Warning: include not used in any version-switcher.html file or include

@netlify
Copy link

netlify bot commented May 15, 2023

Netlify Preview

Name Link
🔨 Latest commit 1792d7f
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/64629eba1a072800082eee50
😎 Deploy Preview https://deploy-preview-16976--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Lauren Hirata Singh and others added 2 commits May 15, 2023 16:22
If `dev` is listed first within `_config_cockroachdb.yml` > versions,
its version tag will be shown as "Dev", even if it's the same as
"Stable". This commit fixes that.
Copy link
Contributor

@nickvigilante nickvigilante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -231,6 +231,10 @@ Asyncpg is commonly used with ORM libraries such as SQLAlchemy to provide a simp

<h5>Change data capture (Changefeeds)</h5>

{{site.data.alerts.callout_info}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, but we have an include for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's edited text from the include

@lnhsingh lnhsingh merged commit 2cc3e24 into master May 15, 2023
@lnhsingh lnhsingh deleted the 23.1.0-rn branch May 15, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants