Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-5772 storage level metrics #16584

Merged
merged 1 commit into from
Mar 24, 2023
Merged

DOC-5772 storage level metrics #16584

merged 1 commit into from
Mar 24, 2023

Conversation

andf-crl
Copy link
Contributor

@andf-crl andf-crl commented Mar 23, 2023 •
edited
Loading

Addresses: DOC-5772

  • Adds 14 new metrics in form: storage.$LEVEL-level-{size,score} of $LEVEL 0 through 6.
  • If you disagree with a metric's description, please change it here: pkg/kv/kvserver/metrics.go.
  • EDIT: just noticed that you backported this. Docs had no idea. I've backported the docs change now too.

Staging

@netlify
Copy link

netlify bot commented Mar 23, 2023 •
edited
Loading

✅ Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit 2548943
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/641cc31dbd03fa00088dcd3e
😎 Deploy Preview https://deploy-preview-16584--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@andf-crl andf-crl requested a review from nicktrav March 23, 2023 21:20
@andf-crl andf-crl force-pushed the DOC-5772-storage-level-metrics branch from cf57c71 to 2548943 Compare March 23, 2023 21:22
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Mar 23, 2023
Closed
nicktrav
nicktrav approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicktrav nicktrav requested a review from jbowens March 23, 2023 23:34
@andf-crl
Copy link
Contributor Author

Thanks!

@andf-crl andf-crl merged commit e8ce3b9 into cockroachdb:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktrav nicktrav nicktrav approved these changes

@jbowens jbowens Awaiting requested review from jbowens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andf-crl @nicktrav