Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include AZURE_ENVIRONMENT parameter for cloud storage docs #16137

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Include AZURE_ENVIRONMENT parameter for cloud storage docs #16137

merged 5 commits into from
Feb 3, 2023

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented Jan 27, 2023 •
edited
Loading

Fixes DOC-3458

Adds the AZURE_ENVIRONMENT parameter to the cdc and cloud storage documentation for v21.2, v22.1, v22.2

@github-actions
Copy link

Files changed:

@netlify
Copy link

netlify bot commented Jan 27, 2023 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 4fc5c06
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/63dd3786c33ac60008e3f899
😎 Deploy Preview https://deploy-preview-16137--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kathancox kathancox requested a review from adityamaru January 27, 2023 21:39
@kathancox
Copy link
Contributor Author

Hey @adityamaru, could you review this quick docs addition? For context: cockroachdb/cockroach#80800

@adityamaru
Copy link

The values we accept for AZURE_ENVIRONMENT are:

"AZURECHINACLOUD"
"AZUREGERMANCLOUD"
"AZUREPUBLICCLOUD"
"AZUREUSGOVERNMENTCLOUD"

Azure docs are not very good on what these environments differ in but my read of the code is that depending on the Cloud Environment there are different sets of endpoints that the user can interact with. The link in your PR seems the most appropriate place to link to, but we should probably specify the values we accept in this parameter, and maybe a line about what that means?

adityamaru
adityamaru approved these changes Jan 31, 2023
View reviewed changes
Copy link

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kathancox
Copy link
Contributor Author

The values we accept for AZURE_ENVIRONMENT are:

"AZURECHINACLOUD" "AZUREGERMANCLOUD" "AZUREPUBLICCLOUD" "AZUREUSGOVERNMENTCLOUD"

Azure docs are not very good on what these environments differ in but my read of the code is that depending on the Cloud Environment there are different sets of endpoints that the user can interact with. The link in your PR seems the most appropriate place to link to, but we should probably specify the values we accept in this parameter, and maybe a line about what that means?

Ah yesss, sorry didn't gather the values from the PR — my mistake. Yes, what to link to is a little tricky, there is a lot of documentation around US Gov, so I have added that here. From the documentation, it looked like the German cloud env is not having any further development against it.

@kathancox kathancox requested a review from andf-crl January 31, 2023 15:34
andf-crl
andf-crl approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@andf-crl andf-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small optional layout comments. Thanks!

v21.2/changefeed-sinks.md Outdated Show resolved Hide resolved
v22.2/use-cloud-storage-for-bulk-operations.md Outdated Show resolved Hide resolved
v22.1/use-cloud-storage-for-bulk-operations.md Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4fc5c06
Status: ✅  Deploy successful!
Preview URL: https://72b8d6db.docs-7ke.pages.dev
Branch Preview URL: https://support-azure-env-param.docs-7ke.pages.dev

View logs

@vercel
Copy link

vercel bot commented Feb 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ❌ Failed (Inspect) Feb 3, 2023 at 4:34PM (UTC)

@kathancox kathancox force-pushed the support-azure-env-param branch from 5c064b3 to 5970967 Compare February 3, 2023 16:14
@kathancox kathancox merged commit 4efa57b into master Feb 3, 2023
@kathancox kathancox deleted the support-azure-env-param branch February 3, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andf-crl andf-crl andf-crl approved these changes

@adityamaru adityamaru adityamaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kathancox @adityamaru @andf-crl