Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-3033 report stuck replicas in decom #14547

Merged

Conversation

andf-crl
Copy link
Contributor

@andf-crl andf-crl commented Jul 14, 2022

Addresses: DOC-3033

This feature has now been backported to v22.1 (#79516)

  • node-shutdown.md : added mention of possible decommission stall detected message to both "Decommissioning" and "Decommission the node" sections
  • cockroach-node.md : added mention of possible decommission stall detected message to "node decommission" output section.

v22.1/node-shutdown.md | v22.1/cockroach-node.md

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andf-crl andf-crl force-pushed the DOC-3033-report-slow-decom-replicas branch from 3eb1db8 to 8177f0b Compare July 14, 2022 20:48
@netlify
Copy link

netlify bot commented Jul 14, 2022

Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit 3eb1db8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/62d080b571125300089ca4e1
😎 Deploy Preview https://deploy-preview-14547--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 14, 2022

Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit 453464f
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/62d1a5395cb0ce0008dd08fc
😎 Deploy Preview https://deploy-preview-14547--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@andf-crl andf-crl force-pushed the DOC-3033-report-slow-decom-replicas branch 3 times, most recently from 6d12db8 to 7407182 Compare July 15, 2022 16:48
@andf-crl andf-crl force-pushed the DOC-3033-report-slow-decom-replicas branch from 7407182 to 453464f Compare July 15, 2022 17:34
@andf-crl andf-crl requested a review from cameronnunez July 15, 2022 17:52
@andf-crl
Copy link
Contributor Author

andf-crl commented Aug 4, 2022

@cameronnunez Friendly ping for review!

Copy link
Contributor Author

@andf-crl andf-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment for review guide. Please ignore.

@cockroachdb cockroachdb deleted a comment from mikeCRL Aug 5, 2022
Copy link

@cameronnunez cameronnunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Sorry for the late review, combination of PTO and sick time.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@andf-crl
Copy link
Contributor Author

@cameronnunez no worries, TYFR!

Copy link
Contributor

@MichaelTrestman MichaelTrestman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andf-crl andf-crl merged commit d66121b into cockroachdb:master Aug 16, 2022
@andf-crl
Copy link
Contributor Author

@MichaelTrestman TYFR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants