Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more detailed Pebble docs on LSMs, etc #13141

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add more detailed Pebble docs on LSMs, etc #13141

merged 1 commit into from
Apr 20, 2022

Conversation

rmloveland
Copy link
Contributor

@rmloveland rmloveland commented Mar 1, 2022 •
edited
Loading

Fixes DOC-1501

Summary of changes:

  • Add new section on LSMs to Architecture > Storage Layer docs

  • Add links to the above from:

    • The UI Overload Dashboard's 'LSM L0 Health' metric

    • The 'LSM Health' section of the Common Issues page

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited
Loading

Files changed:

@rmloveland rmloveland force-pushed the 20220222-pebble-lsm-info branch from 16e873e to d5ff550 Compare March 2, 2022 21:56
@rmloveland rmloveland changed the title (WIP) Add more detailed Pebble docs on LSMs, etc Add more detailed Pebble docs on LSMs, etc Mar 2, 2022
@rmloveland rmloveland marked this pull request as ready for review March 2, 2022 21:58
@netlify
Copy link

netlify bot commented Mar 2, 2022 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 9885808
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6260279eaa9cf90008c94df5
😎 Deploy Preview https://deploy-preview-13141--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rmloveland rmloveland requested a review from itsbilal March 23, 2022 17:29
@rmloveland
Copy link
Contributor Author

Bilal, sorry for the delay, I forgot to add you as reviewer after we spoke recently - hope that is still ok based on our prior convo

@rmloveland
Copy link
Contributor Author

@itsbilal are you still ok to review this? totes happy to ask someone else on the team if bandwidth

itsbilal
itsbilal approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - this is looking really solid! Thanks for writing this up. Just some minor comments and then this is good to go I think.

v21.2/architecture/storage-layer.md Outdated Show resolved Hide resolved
v21.2/architecture/storage-layer.md Outdated Show resolved Hide resolved
v21.2/architecture/storage-layer.md Outdated Show resolved Hide resolved
v21.2/architecture/storage-layer.md Outdated Show resolved Hide resolved
v21.2/architecture/storage-layer.md Outdated Show resolved Hide resolved
v21.2/architecture/storage-layer.md Outdated Show resolved Hide resolved
@rmloveland rmloveland force-pushed the 20220222-pebble-lsm-info branch from d5ff550 to 5c6eff0 Compare April 6, 2022 15:21
@rmloveland
Copy link
Contributor Author

@itsbilal i think most of your feedback is addressed so moving this along to docs review

but please shout if you think some more changes are needed!

@itsbilal
Copy link
Member

Yep it looks good save for a very minor comment about another use of ingested - thanks!

@rmloveland rmloveland force-pushed the 20220222-pebble-lsm-info branch from 5c6eff0 to fdaf4a3 Compare April 12, 2022 19:16
ericharmeling
ericharmeling approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool stuff. Thanks for the good read! LGTM

Reviewed 3 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @itsbilal and @rmloveland)

@rmloveland
Add more detailed Pebble docs on LSMs, SSTs, etc
9885808 
Fixes DOC-1501

Summary of changes:

- Add new section on LSMs to Architecture > Storage Layer docs

- Add links to the above from:

  - The UI Overload Dashboard's 'LSM L0 Health' metric

  - The 'LSM Health' section of the Common Issues page

- (Above changes made to both v21.2 and v22.1)
@rmloveland rmloveland force-pushed the 20220222-pebble-lsm-info branch from fdaf4a3 to 9885808 Compare April 20, 2022 15:32
@rmloveland
Copy link
Contributor Author

Thanks Bilal and Eric for your reviews! FYI I have ported the changes to v22.1 docs as well

@rmloveland rmloveland merged commit 3b291ad into master Apr 20, 2022
@rmloveland rmloveland deleted the 20220222-pebble-lsm-info branch April 20, 2022 15:38
@rmloveland rmloveland mentioned this pull request Apr 21, 2022
Closed
@ekmixon ekmixon mentioned this pull request Dec 1, 2023
Open
@ekmixon ekmixon mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsbilal itsbilal itsbilal approved these changes

@ericharmeling ericharmeling ericharmeling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmloveland @cockroach-teamcity @itsbilal @ericharmeling