21.1 Known Limitations #10568

ericharmeling · 2021-05-13T22:42:58Z

Fixes #9396.
Fixes #7524.
Fixes #7188.
Fixes #8955.
Fixes #10346.

Related to cockroachdb/cockroach#59649.
Related to cockroachdb/cockroach#56492.

cockroach-teamcity · 2021-05-13T22:43:06Z

This change is

github-actions · 2021-05-13T22:43:28Z

Files changed:

cockroachcloud/stream-changefeed-to-snowflake-aws.md
v20.1/bytes.md
v20.1/known-limitations.md
v20.2/bytes.md
v20.2/known-limitations.md
v20.2/postgresql-compatibility.md
v21.1/bytes.md
v21.1/common-table-expressions.md
v21.1/known-limitations.md
v21.1/postgresql-compatibility.md

netlify · 2021-05-14T15:51:17Z

Netlify Preview

Built with commit b60cb6e

https://deploy-preview-10568--cockroachdb-docs.netlify.app

ericharmeling · 2021-05-14T16:14:07Z

v21.1/known-limitations.md

@@ -386,6 +443,10 @@ When inserting/updating all columns of a table, and the table has no secondary i

 This issue is particularly relevant when using a simple SQL table of two columns to [simulate direct KV access](sql-faqs.html#can-i-use-cockroachdb-as-a-key-value-store). In this case, be sure to use the `UPSERT` statement.

+### Size limits on statement input from SQL clients


ericharmeling · 2021-05-14T16:14:22Z

v21.1/known-limitations.md

@@ -130,34 +285,11 @@ CockroachDB supports efficiently storing and querying [spatial data](spatial-dat

    [Tracking GitHub Issue](https://github.com/cockroachdb/cockroach/issues/55227)

-### Collation names that include upper-case or hyphens may cause errors
+- CockroachDB does not support using [schema name prefixes](sql-name-resolution.html#how-name-resolution-works) to refer to [data types](data-types.html) with type modifiers (e.g., `public.geometry(linestring, 4326)`). Instead, use fully-unqualified names to refer to data types with type modifiers (e.g., `geometry(linestring,4326)`).


ericharmeling · 2021-05-14T16:14:36Z

v21.1/known-limitations.md

+## New limitations
+
+### CockroachDB does not properly optimize some left and inverted joins with inverted indexes
+


just a couple of nits, otherwise LGTM - thanks!

ericharmeling · 2021-05-14T16:14:47Z

v21.1/bytes.md

@@ -30,6 +30,10 @@ is otherwise expected.

 The size of a `BYTES` value is variable, but it's recommended to keep values under 1 MB to ensure performance. Above that threshold, [write amplification](https://en.wikipedia.org/wiki/Write_amplification) and other considerations may cause significant performance degradation.  

+{{site.data.alerts.callout_success}}
+If your application requires large binary input in single queries, you can store the blobs somewhere your client can access them (using a cloud storage service, for example), and then reference their addresses from a statement.


ericharmeling · 2021-05-14T16:17:02Z

Adding relevant engineers to review specific limitations. Thank you!

rytaft · 2021-05-15T01:12:42Z

v21.1/known-limitations.md

+## New limitations
+
+### CockroachDB does not properly optimize some left and inverted joins with inverted indexes
+


just a couple of nits, otherwise LGTM - thanks!

rytaft · 2021-05-15T01:12:54Z

v21.1/known-limitations.md

+
+### CockroachDB does not properly optimize some left and inverted joins with inverted indexes
+
+[Left joins](joins.html#left-outer-joins) and [inverted joins](joins.html#inverted-joins) involving [`JSONB`](jsonb.html), [`ARRAY`](array.html), or [spatial-typed](spatial-data.html) columns with a multi-column or [partitioned](partition-by.html) [inverted index](inverted-indexes.html) will not take advantage of the index if the prefix columns of the index are unconstrained, or if they are constrained to multiple, constant values.


nit: this should say left joins and anti joins (it's true the relevant algorithm is inverted join, but the limitation is only for left and anti joins, not inner or semi joins).

rytaft · 2021-05-15T01:13:08Z

v21.1/known-limitations.md

+
+[Left joins](joins.html#left-outer-joins) and [inverted joins](joins.html#inverted-joins) involving [`JSONB`](jsonb.html), [`ARRAY`](array.html), or [spatial-typed](spatial-data.html) columns with a multi-column or [partitioned](partition-by.html) [inverted index](inverted-indexes.html) will not take advantage of the index if the prefix columns of the index are unconstrained, or if they are constrained to multiple, constant values.
+
+To work around this limitation, make sure that the prefix columns of the index are either constrained to single constant values, or are the same as the input columns.


nit: "the same as input columns" is misleading -- I think this should be referring to equality conditions. If the prefix columns are not held constant, they should be part of equality conditions (e.g., col1 = col2), where col1 is a prefix column and col2 is an input column.

jseldess

, after addressing feedback form others.

@ericharmeling, please make sure that any corresponding cockroach GH issues have the docs-done label added. That gives us a quick way to know that a known limitations has been documented.

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @bdarnell, @ericharmeling, and @otan)

v20.1/known-limitations.md, line 485 at r2 (raw file):

This issue is particularly relevant when using a simple SQL table of two columns to [simulate direct KV access](sql-faqs.html#can-i-use-cockroachdb-as-a-key-value-store). In this case, be sure to use the `UPSERT` statement.

### Size limits on statement input from SQL clients

Do we have a GH issue to link to here, or is this something we don't plan to fix/change over time?

Also, add final period.

v20.2/known-limitations.md, line 352 at r2 (raw file):

This issue is particularly relevant when using a simple SQL table of two columns to [simulate direct KV access](sql-faqs.html#can-i-use-cockroachdb-as-a-key-value-store). In this case, be sure to use the `UPSERT` statement.

### Size limits on statement input from SQL clients

Same as before: Do we have a GH issue to link to here, or is this something we don't plan to fix/change over time?.

Also, add final period.

v21.1/bytes.md, line 34 at r2 (raw file):

Previously, ericharmeling (Eric Harmeling) wrote…

@bdarnell

Same as above.

otan

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @bdarnell and @ericharmeling)

v21.1/known-limitations.md, line 288 at r2 (raw file):

Previously, ericharmeling (Eric Harmeling) wrote…

@otan

This should be the case for 20.2 as well.

github-actions · 2021-05-17T14:36:17Z

Files changed:

cockroachcloud/stream-changefeed-to-snowflake-aws.md
v20.1/bytes.md
v20.1/known-limitations.md
v20.2/bytes.md
v20.2/known-limitations.md
v20.2/postgresql-compatibility.md
v21.1/bytes.md
v21.1/common-table-expressions.md
v21.1/known-limitations.md
v21.1/postgresql-compatibility.md

ericharmeling

TFTR @jseldess, @rytaft, @otan!

I believe I've addressed everyone's comments.

@jseldess I added those docs-done labels, now that this is approved.

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @bdarnell and @jseldess)

v20.1/known-limitations.md, line 485 at r2 (raw file):

Do we have a GH issue to link to here, or is this something we don't plan to fix/change over time?

I don't believe that there is a GitHub issue to resolve this specific limitation.

A quote from this thread:

"... the 16 MiB limit is in our implementation of the postgres network protocol. it's a magic number we could change, but we've mainly discussed that in the context of lowering it, not raising it. "

So it appears that any changes made would lower that hard limit (making the limitation more restrictive), but not remove it.

Also, add final period.

Done.

v20.2/known-limitations.md, line 352 at r2 (raw file):

Do we have a GH issue to link to here, or is this something we don't plan to fix/change over time?

See my comment above.

Also, add final period.

Done.

v21.1/bytes.md, line 34 at r2 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

Same as above.

This is a tip from that same thread about size limits on SQL statement input.

I discussed with Ben here, and I agree with his suggestion to make this tip an extension of the size recommendations on this particular type, rather than overcomplicate the stated limitation on SQL input size.

v21.1/known-limitations.md, line 13 at r2 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

nit: this should say left joins and anti joins (it's true the relevant algorithm is inverted join, but the limitation is only for left and anti joins, not inner or semi joins).

Done.

v21.1/known-limitations.md, line 15 at r2 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

nit: "the same as input columns" is misleading -- I think this should be referring to equality conditions. If the prefix columns are not held constant, they should be part of equality conditions (e.g., col1 = col2), where col1 is a prefix column and col2 is an input column.

Done.

v21.1/known-limitations.md, line 288 at r2 (raw file):

Previously, otan (Oliver Tan) wrote…

This should be the case for 20.2 as well.

Done.

rytaft

Reviewed 1 of 3 files at r3.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @bdarnell, @ericharmeling, and @jseldess)

v21.1/known-limitations.md, line 613 at r3 (raw file):

### Inverted indexes cannot be partitioned

CockroachDB does not support partitioning inverted indexes, including [spatial indexes](spatial-indexes.html).

This is no longer a limitation. 21.1 supports partitioning of inverted indexes.

ericharmeling

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @bdarnell, @jseldess, and @rytaft)

v21.1/known-limitations.md, line 613 at r3 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

This is no longer a limitation. 21.1 supports partitioning of inverted indexes.

Good catch!

Removed.

github-actions · 2021-05-17T15:19:16Z

Files changed:

cockroachcloud/stream-changefeed-to-snowflake-aws.md
v20.1/bytes.md
v20.1/known-limitations.md
v20.2/bytes.md
v20.2/known-limitations.md
v20.2/postgresql-compatibility.md
v21.1/bytes.md
v21.1/common-table-expressions.md
v21.1/known-limitations.md
v21.1/postgresql-compatibility.md

ericharmeling · 2021-05-17T15:33:43Z

Merging so this can go out with the GA 21.1 release notes - @bdarnell, feel free to leave feedback after the merge if you'd like to. I'm happy to make updates as-needed.

21.1 Known Limitations

eb6d464

link fix

ac5c59b

ericharmeling requested review from otan, bdarnell and rytaft May 14, 2021 16:13

ericharmeling commented May 14, 2021

View reviewed changes

ericharmeling requested a review from jseldess May 14, 2021 22:01

rytaft reviewed May 15, 2021

View reviewed changes

jseldess approved these changes May 16, 2021

View reviewed changes

otan reviewed May 16, 2021

View reviewed changes

feedback

ad2b421

ericharmeling commented May 17, 2021

View reviewed changes

rytaft reviewed May 17, 2021

View reviewed changes

Removed inverted index partition limitation

b60cb6e

ericharmeling commented May 17, 2021

View reviewed changes

ericharmeling merged commit 34da877 into master May 17, 2021

ericharmeling deleted the 211-known-limitations branch July 28, 2021 18:37

ericharmeling mentioned this pull request Oct 14, 2021

Reinstated correlated CTE known limitation in 21.1 #11973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

21.1 Known Limitations #10568

21.1 Known Limitations #10568

ericharmeling commented May 13, 2021 •

edited

Loading

cockroach-teamcity commented May 13, 2021

github-actions bot commented May 13, 2021

netlify bot commented May 14, 2021 •

edited

Loading

ericharmeling May 14, 2021

ericharmeling May 14, 2021

ericharmeling May 14, 2021

rytaft May 15, 2021

ericharmeling May 14, 2021

ericharmeling commented May 14, 2021

rytaft May 15, 2021

rytaft May 15, 2021

rytaft May 15, 2021

jseldess left a comment

otan left a comment

github-actions bot commented May 17, 2021

ericharmeling left a comment

rytaft left a comment

ericharmeling left a comment

github-actions bot commented May 17, 2021

ericharmeling commented May 17, 2021

		@@ -386,6 +443,10 @@ When inserting/updating all columns of a table, and the table has no secondary i

		This issue is particularly relevant when using a simple SQL table of two columns to [simulate direct KV access](sql-faqs.html#can-i-use-cockroachdb-as-a-key-value-store). In this case, be sure to use the `UPSERT` statement.

		### Size limits on statement input from SQL clients

		## New limitations

		### CockroachDB does not properly optimize some left and inverted joins with inverted indexes


		### CockroachDB does not properly optimize some left and inverted joins with inverted indexes

		[Left joins](joins.html#left-outer-joins) and [inverted joins](joins.html#inverted-joins) involving [`JSONB`](jsonb.html), [`ARRAY`](array.html), or [spatial-typed](spatial-data.html) columns with a multi-column or [partitioned](partition-by.html) [inverted index](inverted-indexes.html) will not take advantage of the index if the prefix columns of the index are unconstrained, or if they are constrained to multiple, constant values.


		[Left joins](joins.html#left-outer-joins) and [inverted joins](joins.html#inverted-joins) involving [`JSONB`](jsonb.html), [`ARRAY`](array.html), or [spatial-typed](spatial-data.html) columns with a multi-column or [partitioned](partition-by.html) [inverted index](inverted-indexes.html) will not take advantage of the index if the prefix columns of the index are unconstrained, or if they are constrained to multiple, constant values.

		To work around this limitation, make sure that the prefix columns of the index are either constrained to single constant values, or are the same as the input columns.

21.1 Known Limitations #10568

21.1 Known Limitations #10568

Conversation

ericharmeling commented May 13, 2021 • edited Loading

cockroach-teamcity commented May 13, 2021

github-actions bot commented May 13, 2021

netlify bot commented May 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericharmeling commented May 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jseldess left a comment

Choose a reason for hiding this comment

otan left a comment

Choose a reason for hiding this comment

github-actions bot commented May 17, 2021

ericharmeling left a comment

Choose a reason for hiding this comment

rytaft left a comment

Choose a reason for hiding this comment

ericharmeling left a comment

Choose a reason for hiding this comment

github-actions bot commented May 17, 2021

ericharmeling commented May 17, 2021

ericharmeling commented May 13, 2021 •

edited

Loading

netlify bot commented May 14, 2021 •

edited

Loading