Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to practical example of splitting large txns #10384

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

rmloveland
Copy link
Contributor

Relates to #4409, #7524.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rmloveland
Copy link
Contributor Author

Eric this is not new info, but I was surprised that our statements to "make them smaller" weren't linked up to something that said how to do that. Let me know if you think these are wrong (I don't think so? but it's late afternoon, ha)

Copy link
Contributor

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you're right. Looks good - thank you!

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rmloveland)

@rmloveland rmloveland merged commit aed2377 into master Apr 21, 2021
@rmloveland rmloveland deleted the 20210420-making-txns-smaller-example branch April 21, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants