Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify stats deletion procedures across DELETE and main CBO pages #4872

Closed
rmloveland opened this issue Jun 4, 2019 · 1 comment
Closed

Unify stats deletion procedures across DELETE and main CBO pages #4872

rmloveland opened this issue Jun 4, 2019 · 1 comment
Assignees
@rmloveland
Labels
C-doc-improvement P-2 Normal priority; secondary task T-incorrect-or-unclear-info
Milestone
19.2

Comments

@rmloveland
Copy link
Contributor

Quoth @RaduBerinde in #4635:

I noticed there is another page which mentions how to delete statistics, but it doesn't mention the "restart to clear cache part": https://www.cockroachlabs.com/docs/stable/create-statistics.html#delete-statistics

Should we update that too? Or just have it link to the CBO section?

Estimated scope of work:

  • Resolve inconsistency noted by Radu above
  • ... ideally, by revamping this information so it's the same in multiple places

Could be as simple as linking to the CBO section, but an include that makes the info available wherever it is used is probably the right thing.
@rmloveland rmloveland mentioned this issue Jun 4, 2019
Merged
@rmloveland rmloveland self-assigned this Jun 17, 2019
@rmloveland rmloveland added A-sql P-2 Normal priority; secondary task labels Jun 17, 2019
rmloveland added a commit that referenced this issue Jun 17, 2019
@rmloveland
Update docs on automatic stats refresh rate
ee681b7 
... and node restarts after stats deletion to clear caches.

Summary of changes:

- Add a new subsection to CBO page, 'Controlling statistics refresh
  rate', where we describe the cases when stats are refreshed in more
  detail.

- To match the structure of the above, we break the instructions for
  deleting stats into a new section 'Turning off statistics'

- Finally, tweak stats deletion instructions on CBO page and CREATE
  STATS page so both say that nodes must be restarted
  post-stats-deletion to clear caches.

Fixes #4809, #4872.
@rmloveland rmloveland mentioned this issue Jun 17, 2019
Merged
rmloveland added a commit that referenced this issue Jun 19, 2019
@rmloveland
Update docs on automatic stats refresh rate
ed3431e 
... and node restarts after stats deletion to clear caches.

Summary of changes:

- Add a new subsection to CBO page, 'Controlling statistics refresh
  rate', where we describe the cases when stats are refreshed in more
  detail.

- To match the structure of the above, we break the instructions for
  deleting stats into a new section 'Turning off statistics'

- Finally, tweak stats deletion instructions on CBO page and CREATE
  STATS page so both say that nodes must be restarted
  post-stats-deletion to clear caches.

Fixes #4809, #4872.
rmloveland added a commit that referenced this issue Jun 20, 2019
@rmloveland
Update docs on automatic stats refresh rate
9e305bd 
... and node restarts after stats deletion to clear caches.

Summary of changes:

- Add a new subsection to CBO page, 'Controlling statistics refresh
  rate', where we describe the cases when stats are refreshed in more
  detail.

- To match the structure of the above, we break the instructions for
  deleting stats into a new section 'Turning off statistics'

- Finally, tweak stats deletion instructions on CBO page and CREATE
  STATS page so both say that nodes must be restarted
  post-stats-deletion to clear caches.

Fixes #4809, #4872.
@jseldess jseldess added this to the 19.2 milestone Jun 20, 2019
@rmloveland
Copy link
Contributor Author

Fixed in #4925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
C-doc-improvement P-2 Normal priority; secondary task T-incorrect-or-unclear-info
Projects
None yet
Milestone
19.2
Development

No branches or pull requests
2 participants
@rmloveland @jseldess