Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete/incorrect release notes #3252

Closed
knz opened this issue Jun 5, 2018 · 2 comments
Closed

Incomplete/incorrect release notes #3252

knz opened this issue Jun 5, 2018 · 2 comments
Assignees

Comments

@knz
Copy link
Contributor

knz commented Jun 5, 2018

https://forum.cockroachlabs.com/t/release-notes-for-cockroachdb-v2-1-alpha-20180604/1711

  • The latest published release note have an item that reads "It is now possible to use ALTER TABLE ... " but there is no issue or PR reference and it doesn't really say what it does.
  • "order of precendence" should read "order of precedence"
  • "Documented the TIMETZ data type. Document the TIMETZ type #3102 " - this is incorrect, we have pulled the TIMETZ doc for now because the implementation is invalid/incorrect
  • the contributor "yuzefovich" is Yahor and his name should be spelled in full.
@jseldess
Copy link
Contributor

jseldess commented Jun 5, 2018

@knz:

  • The first bullet was already fixed in the release notes on our site. The fix was missing from the forum. I just fixed it there, too.
  • Fixed misspelling of "precedence" in forum and in published notes.
  • That's not correct. TIMETZ docs are, in fact, still live.
  • Fixed Yahor's name. Can you update the script to do that automatically?

@knz
Copy link
Contributor Author

knz commented Jun 5, 2018

I have filed cockroachdb/cockroach#26410 already

As for TIMETZ I have a sad frown on my face. TIMETZ is utterly broken right now and I'd rather users not try it... Especially because the fix will be backward-incompatible.

craig bot pushed a commit to cockroachdb/cockroach that referenced this issue Jun 5, 2018
26410: scripts: add Yahor to release notes script r=knz a=knz

needed to prevent future occurrences of cockroachdb/docs#3252

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants