Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on node draining #2436

Closed
andreimatei opened this issue Jan 29, 2018 · 3 comments
Closed

Update docs on node draining #2436

andreimatei opened this issue Jan 29, 2018 · 3 comments
Assignees
Milestone

Comments

@andreimatei
Copy link
Contributor

Re: Stop a Node

Our nodes do a couple of dances when they're being shut down so that impact on running queries, and on clients continuously sending queries, is minimized. The behavior and the timeouts involved should be documented. I think @asubiotto has become the expert.

@jseldess
Copy link
Contributor

@andreimatei, I think this is documented at a high-level under "how it works". Definitely interesting in making this more detailed, though.

@asubiotto
Copy link
Contributor

We could enhance that with an explanation of what happens to client connections and in-flight queries (some work being done on the distsql side of things: cockroachdb/cockroach#20450)

@jseldess jseldess changed the title Draining of nodes should be documented Update docs on node draining Feb 14, 2018
@jseldess
Copy link
Contributor

Also involves documenting the new server.drain_max_wait cluster setting, which sets the max amount of time to wait for distributed queries to finish before the node starts draining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants