Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #98390 - cli: compute --drain-wait based on cluster setting values #16494

Open
cockroach-teamcity opened this issue Mar 15, 2023 · 0 comments

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 15, 2023

Exalate commented:

Related PR: cockroachdb/cockroach#98390
Commit: cockroachdb/cockroach@18eac87
Fixes: cockroachdb/cockroach#98388


Release note (cli change): The --drain-wait argument for the drain
command will be automatically increased if the command detects that it
is smaller than the sum of server.shutdown.drain_wait,
server.shutdown.connection_wait, server.shutdown.query_wait times two,
and server.shutdown.lease_transfer_wait. If the --drain-wait argument is
0, then no timeout is used.

This recommendation was already documented, but now the advice will be
applied automatically.

Jira Issue: DOC-7204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant