add support for CockroachDB 21.2 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
v21.2
branch
2 times, most recently
from
ac16940 to
2ce8b9c
Compare
timgraham
force-pushed
the
v21.2
branch
3 times, most recently
from
b52a274 to
5d5cd92
Compare
timgraham
commented
Oct 26, 2021
django_cockroachdb/features.py
Outdated
| @@ -180,6 +186,9 @@ def django_test_expected_failures(self): | |||
| 'model_fields.test_jsonfield.TestQuerying.test_order_grouping_custom_decoder', | |||
| 'model_fields.test_jsonfield.TestQuerying.test_ordering_by_transform', | |||
| 'model_fields.test_jsonfield.TestQuerying.test_ordering_grouping_by_key_transform', | |||
| # cannot index a json element: | |||
| # https://github.com/cockroachdb/cockroach/issues/30690 | |||
There was a problem hiding this comment.
Should this be reopened or a new issue opened?
There was a problem hiding this comment.
i think we can link to this one cockroachdb/cockroach#35706
timgraham
changed the title
timgraham
force-pushed
the
v21.2
branch
2 times, most recently
from
bb2a448 to
f57c541
Compare
rafiss
approved these changes
Nov 16, 2021
| # ALTER COLUMN ... SET NOT NULL crashes with "validate check | ||
| # constraint: column "crdb_internal_idx_expr" does not exist": | ||
| # https://github.com/cockroachdb/cockroach/issues/72012 | ||
| 'migrations.test_operations.OperationTests.test_alter_field_with_func_index', |
There was a problem hiding this comment.
I'm sure you've seen this already, but this will be fixed in v21.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.