Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: jobsprofiler: store DistSQL diagram of jobs in job info #99821

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 28, 2023

Backport 1/1 commits from #99522 on behalf of @adityamaru.

/cc @cockroachdb/release


This change teaches import, cdc, backup and restore
to store their DistSQL plans in the job_info table
under a timestamped info key. The generation and writing
of the plan diagram is done asynchronously so as to not
slow down the execution of the job. A new plan will be
stored everytime the job sets up its DistSQL flow.

Release note: None
Epic: CRDB-8964
Informs: #99729


Release justification: low risk change to provide observability into the distribution of work during job execution

This change teaches import, cdc, backup and restore
to store their DistSQL plans in the job_info table
under a timestamped info key. The generation and writing
of the plan diagram is done asynchronously so as to not
slow down the execution of the job. A new plan will be
stored everytime the job sets up its DistSQL flow.

Release note: None
Epic: CRDB-8964
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99522 branch from bb11b30 to c1393d4 Compare March 28, 2023 16:36
@blathers-crl blathers-crl bot requested review from a team as code owners March 28, 2023 16:36
@blathers-crl blathers-crl bot requested review from a team and benbardin and removed request for a team March 28, 2023 16:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99522 branch from f0719c7 to 189e7c3 Compare March 28, 2023 16:36
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from miretskiy and removed request for a team March 28, 2023 16:36
@blathers-crl blathers-crl bot closed this Mar 28, 2023
@blathers-crl blathers-crl bot deleted the blathers/backport-release-23.1-99522 branch March 28, 2023 16:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz restored the blathers/backport-release-23.1-99522 branch March 28, 2023 16:42
@knz knz reopened this Mar 28, 2023
@adityamaru adityamaru requested review from dt and removed request for benbardin March 29, 2023 13:49
@adityamaru adityamaru merged commit 2a1fc4b into release-23.1 Mar 29, 2023
@adityamaru adityamaru deleted the blathers/backport-release-23.1-99522 branch March 29, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants