-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud: add optional connection timeout retries #99811
Merged
dt
merged 1 commit into
cockroachdb:release-22.2
from
stevendanna:retry-connection-timeout
Mar 28, 2023
Merged
cloud: add optional connection timeout retries #99811
dt
merged 1 commit into
cockroachdb:release-22.2
from
stevendanna:retry-connection-timeout
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
stevendanna
commented
Mar 28, 2023
stevendanna
force-pushed
the
retry-connection-timeout
branch
from
March 28, 2023 15:52
148a659
to
0de35f3
Compare
stevendanna
commented
Mar 28, 2023
stevendanna
force-pushed
the
retry-connection-timeout
branch
from
March 28, 2023 22:19
84c9ee2
to
c63e1a4
Compare
dt
approved these changes
Mar 28, 2023
This optionally adds connection timeout errors to the set of errors to retry in the resuming reader. Additionally, it adds the file name to error messages returned by the resuming reader. We test for ETIMEDOUT. Linux returns ETIMEDOUT in cases where the remote end of a connection fails to acknowledge a configured number of TCP Keep-Alive messages. This shouldn't catch timeouts that are the result of IO deadlines or context cancellations. But, just in case we've put this behind a cluster setting to avoid changing behaviour. Epic: none Release note: None
stevendanna
force-pushed
the
retry-connection-timeout
branch
from
March 28, 2023 22:27
c63e1a4
to
e5862c2
Compare
For the permanent record, I tested this by:
With the setting set to false, the error is returned to the user. With the setting set to true, we get a retry:
|
does this need a forward port to master and 23.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optionally adds connection timeout errors to the set of errors to retry in the resuming reader. Additionally, it adds the file name to error messages returned by the resuming reader.
We test for ETIMEDOUT. Linux returns ETIMEDOUT in cases where the remote end of a connection fails to acknowledge a configured number of TCP Keep-Alive messages.
This shouldn't catch timeouts that are the result of IO deadlines or context cancellations. But, we don't enable this retrying by default, to avoid changing any current behaviour.
Epic: none
Release note: None