-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: add FIPS-specific channel #99733
Conversation
Previously, all official builds were reporting using the same telemetry channel. This PR adds an new telemetry channel for the FIPS build target. Fixes: CC-24110 Epic: DEVINF-478 Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
bors r=knz |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6100c55 to blathers/backport-release-22.2-99733: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
@knz something tells me that I less care about backporting this to 22.2... What do you think? |
what's your reasoning? |
Because we treat 22.2 as an experimental branch for FIPS. |
let's ask abhinav for input. he's the consumer of the telemetry data after all. |
Sure. Let me see how bad is the conflict meanwhile. |
Previously, all official builds were reporting using the same telemetry channel.
This PR adds an new telemetry channel for the FIPS build target.
Fixes: CC-24110
Epic: DEVINF-478
Release note: None