Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: revert #98150 #99710

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 27, 2023

Backport 2/2 commits from #99643 on behalf of @tbg.

Closes #99707.

/cc @cockroachdb/release


This reverts #98150 because we think it introduced a problem that was detected
via the replicate/wide roachtest1. It seems that for reasons still unknown
we do rely on the periodic gossip trigger on liveness lease extensions.

Touches #99268.
Touches #97966.
Closes #99268.
Touches #98945.

Tracked in #99652.

Epic: none
Release note: None


Release justification: critical bug fix.

Footnotes

  1. roachtest: replicate/wide failed #99268 (comment)

tbg added 2 commits March 27, 2023 12:24
This reverts #98150 because we think it introduced a problem that was detected
via the `replicate/wide` roachtest[^1]. It seems that for reasons still unknown
we do rely on the periodic gossip trigger on liveness lease extensions.

[^1]: #99268 (comment)

Touches #99268.
Touches #97966.
Closes #99268.
Touches #98945.

Epic: none
Release note: None
Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team March 27, 2023 18:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99643 branch 2 times, most recently from 234919b to 887be4d Compare March 27, 2023 18:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99643 branch from 025c660 to 014f091 Compare March 27, 2023 18:48
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 27, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit c2fc854 into release-23.1 Mar 27, 2023
@nvanbenschoten nvanbenschoten deleted the blathers/backport-release-23.1-99643 branch March 27, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants