Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: increase minimal max_range_size to 64MiB #99575

Closed
wants to merge 1 commit into from
Closed

release-23.1: sql: increase minimal max_range_size to 64MiB #99575

wants to merge 1 commit into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 25, 2023

Backport 1/1 commits from #96725 on behalf of @shralex.

/cc @cockroachdb/release

We've seen that small range sizes can be detrimental to various components. This PR makes it so users can't lower max_range_size below 64MiB (half of the default min_range_size), instead of 64KiB previously.

Release note: Small ranges have been known to cause problems in various CRDB subsystems. This PR prevents setting max_range_size below COCKROACH_MIN_RANGE_MAX_BYTES, an environment variable which defaults to 64MiB (half of the default minimum range size).

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-24182
Fixes: #96549

Release justification:

@shralex
kv: increase the minimal max_range_size to 64MiB
ebe4a43 
We've seen that small range sizes can be detrimental to various
components. This PR makes it so users can't lower max_range_size
below 64MiB (half of the default min_range_size), instead of 64KiB previously.

Release Note: Small ranges have been known to cause problems in various
CRDB subsystems. This PR prevents setting max_range_size below
COCKROACH_MIN_RANGE_MAX_BYTES, an environment variable which defaults
to 64MiB (half of the default minimum range size).

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-24182
Fixes: #96549
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 25, 2023 16:35
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-96725 branch from f351747 to e32f819 Compare March 25, 2023 16:35
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 25, 2023 16:35
@blathers-crl blathers-crl bot requested a review from a team March 25, 2023 16:35
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 25, 2023 16:35
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-96725 branch from 3fcb780 to ebe4a43 Compare March 25, 2023 16:35
@blathers-crl blathers-crl bot requested review from rhu713 and removed request for a team March 25, 2023 16:35
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 25, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot closed this Mar 25, 2023
@blathers-crl blathers-crl bot deleted the blathers/backport-release-23.1-96725 branch March 25, 2023 16:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz restored the blathers/backport-release-23.1-96725 branch March 28, 2023 16:50
@knz knz reopened this Mar 28, 2023
@knz
Copy link
Contributor

knz commented Mar 28, 2023

@shralex @rhu713 is this still relevant?

@aliher1911 aliher1911 mentioned this pull request May 31, 2023
Merged
@shralex shralex closed this Jan 2, 2024
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-96725 branch January 31, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhu713 rhu713 Awaiting requested review from rhu713 rhu713 is a code owner automatically assigned from cockroachdb/disaster-recovery

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

@arulajmani arulajmani Awaiting requested review from arulajmani

@adityamaru adityamaru Awaiting requested review from adityamaru

Assignees

@shralex shralex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @knz @shralex