Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logictest: ensure generated ccl build files have the right tags #99521

Merged
merged 1 commit into from
Mar 25, 2023
Merged

logictest: ensure generated ccl build files have the right tags #99521

merged 1 commit into from
Mar 25, 2023

Conversation

healthy-pod
Copy link
Contributor

Release note: None
Epic: none

@healthy-pod healthy-pod requested review from a team as code owners March 24, 2023 21:10
@healthy-pod healthy-pod requested a review from cucaroach March 24, 2023 21:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

andyyang890
andyyang890 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@healthy-pod
Copy link
Contributor Author

bors r=andyyang890

@craig
Copy link
Contributor

craig bot commented Mar 24, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 25, 2023

Build succeeded:

@craig craig bot merged commit 0d84ad5 into cockroachdb:master Mar 25, 2023
@knz
Copy link
Contributor

knz commented Apr 2, 2023

should this be backported?

@andyyang890
Copy link
Collaborator

should this be backported?

I'm gonna guess no since #98834 was not backported.

@healthy-pod healthy-pod deleted the fix-ccl branch April 22, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyyang890 andyyang890 andyyang890 approved these changes

@rickystewart rickystewart Awaiting requested review from rickystewart

@cucaroach cucaroach Awaiting requested review from cucaroach cucaroach was automatically assigned from cockroachdb/sql-queries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@healthy-pod @cockroach-teamcity @knz @andyyang890