server,sql: remove usages of prettify on details pages #99450
Conversation
maryliag
added
backport-22.1.x
backport-23.1.x
|
This change is |
maryliag
force-pushed
the
remove-prettify
branch
2 times, most recently
from
e9d87b6 to
bb95b66
Compare
There was a problem hiding this comment.
Reviewed 2 of 11 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/yarn-vendor line 1 at r1 (raw file):
Subproject commit c0d256e029be53fae2abe2302a0988302a0bb4ec
Is this expected?
maryliag
force-pushed
the
remove-prettify
branch
from
bb95b66 to
ede739f
Compare
The usage of `prettify_statement` and `Pretty` could cause OOM. Those were being used on statemen details and transaction insight details. This commit removes those usages and add a very basic formatting function that can be used on the SQLBox component. Part Of cockroachdb#91197 Release note (performance improvement): Removal of prettify usages that could cause OOM on Statement Details and Transaction Details page.
maryliag
force-pushed
the
remove-prettify
branch
from
ede739f to
350f42b
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/ui/yarn-vendor line 1 at r1 (raw file):
Previously, j82w (Jake) wrote…
Is this expected?
Added by mistake. Removed now
|
bors r+ |
There was a problem hiding this comment.
Reviewed 7 of 11 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status:
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 350f42b to blathers/backport-release-22.1-99450: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from 350f42b to blathers/backport-release-22.2-99450: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
The usage of
prettify_statementandPrettycould cause OOM. Those were being used on statemen details and transaction insight details.This commit removes those usages and add a very basic formatting function that can be used on the SQLBox component.
Part Of #91197
Release note (performance improvement): Removal of prettify usages that could cause OOM on Statement Details and Transaction Details page.