testutils: move default test tenant message #99348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
herkolategan
force-pushed
the
hbl/move-default-tenant-message
branch
6 times, most recently
from
d0820bc to
07929fb
Compare
herkolategan
requested review from
rharding6373,
srosenberg,
renatolabs,
ajstorm and
dt
and removed request for
a team
herkolategan
force-pushed
the
hbl/move-default-tenant-message
branch
from
07929fb to
3acc368
Compare
rharding6373
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajstorm, @dt, @renatolabs, and @srosenberg)
herkolategan
force-pushed
the
hbl/move-default-tenant-message
branch
from
3acc368 to
d309666
Compare
In order to reduce logging noise but still inform test authors of the default test tenant, the message has been moved to where there is a `testing.TB` interface. Epic: CRDB-18499
herkolategan
force-pushed
the
hbl/move-default-tenant-message
branch
from
d309666 to
346bbc9
Compare
|
TFTR! |
|
Build failed: |
|
bors r=rharding6373 |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce logging noise but still inform test authors of the default test tenant, the message has been moved to where there is a
testing.TBinterface.Epic: CRDB-18499