Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: add p99 computed column and index to system.statement_statistics, system.transaction_statistics #99309

Merged
merged 1 commit into from
Mar 23, 2023
Merged

release-23.1: sql: add p99 computed column and index to system.statement_statistics, system.transaction_statistics #99309

merged 1 commit into from
Mar 23, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 22, 2023 •
edited by ericharmeling
Loading

Backport 1/1 commits from #99148 on behalf of @ericharmeling.

/cc @cockroachdb/release

Part of #98624.
Follows #99042.

This commit adds a new computed column (p99_latency) and partial
index (p99_latency_idx) to the system.statement_statistics and
system.transaction_statistics tables.

Epic: none

Release note: None

Release justification: high benefit changes to
existing functionality

@ericharmeling
sql: add p99 computed column and index to system.statement_statistics…
9dc146f 
…, system.transaction_statistics

Part of #98624.
Follows #99042.

This commit adds a new computed column (p99_latency) and partial
index (p99_latency_idx) to the system.statement_statistics and
system.transaction_statistics tables.

The commit also increases the hard-coded fingerprint execution
count for the flush benchmark to the maximum for in-memory
statement stats that trigger a flush.

Epic: none

Release note: None
@blathers-crl blathers-crl bot requested a review from a team March 22, 2023 22:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99148 branch from 1352ad2 to bcf8331 Compare March 22, 2023 22:44
@blathers-crl blathers-crl bot requested a review from a team March 22, 2023 22:44
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 22, 2023 22:44
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99148 branch from 86cf7e4 to 9dc146f Compare March 22, 2023 22:44
@blathers-crl blathers-crl bot requested review from DrewKimball and maryliag March 22, 2023 22:44
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 22, 2023 •
edited by ericharmeling
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 22, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

j82w
j82w approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @maryliag)

@ericharmeling ericharmeling merged commit b3dac53 into release-23.1 Mar 23, 2023
@ericharmeling ericharmeling deleted the blathers/backport-release-23.1-99148 branch March 23, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w approved these changes

@DrewKimball DrewKimball Awaiting requested review from DrewKimball DrewKimball was automatically assigned from cockroachdb/sql-queries

@maryliag maryliag Awaiting requested review from maryliag

Assignees

@ericharmeling ericharmeling

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @j82w @ericharmeling