-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: fix and unskip TestCheckConsistencyInconsistent #99114
Merged
craig
merged 2 commits into
cockroachdb:master
from
pav-kv:fix-and-unskip-consistency-test
Mar 22, 2023
Merged
kvserver: fix and unskip TestCheckConsistencyInconsistent #99114
craig
merged 2 commits into
cockroachdb:master
from
pav-kv:fix-and-unskip-consistency-test
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
bors r=erikgrinaker |
Build failed (retrying...): |
Build failed (retrying...): |
Merge conflict. |
This commit fixes the race possible in TestCheckConsistencyInconsistent: - Node 2 is corrupted. - The second phase of runConsistency check times out on node 1, and returns early when only nodes 2 and 3 have created the storage checkpoint. - Node 1 haven't created the checkpoint, but has started doing so. - Node 2 "fatals" (mocked out in the test) shortly after the check is complete. - Node 1 is still creating its checkpoint, but has probably created the directory by now. - Hence, the test assumes that the checkpoint has been created, and proceeds to open it and compute the checksum of the range. This commit makes the test wait for the moment when all the checkpoint are known to be fully populated. Part of cockroachdb#81819 Epic: none Release note: none
The test was skipped for a reason that no longer holds. Epic: none Release note: none
pav-kv
force-pushed
the
fix-and-unskip-consistency-test
branch
from
March 22, 2023 09:35
a5bbd5c
to
6372b6e
Compare
bors r=erikgrinaker |
Build failed: |
bors retry |
Build failed: |
bors retry |
Build failed: |
bors retry |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unskips
TestCheckConsistencyInconsistent
which was skipped for a reason that no longer holds.It also fixes the race possible in
TestCheckConsistencyInconsistent
:runConsistency
check times out on node 1, and returns early when only nodes 2 and 3 have created the storage checkpoint.The test now waits for the moment when all the checkpoint are known to be fully populated.
Fixes #81819
Epic: none
Release note: none