Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: set 30m timeout for all disk stall roachtests #99045

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Mar 20, 2023

This commit sets a new 30m timeout for all disk stall roachtests. Previously,
the FUSE filesystem variants had no timeout and inherited the default 10h
timeout. The other variants had a 20m timeout, which has been observed to be
too short due to upreplication latency.

Informs #98904.
Informs #98886.
Epic: None
Release note: None

@jbowens jbowens requested a review from a team March 20, 2023 17:59
@jbowens jbowens requested a review from a team as a code owner March 20, 2023 17:59
@jbowens jbowens requested a review from bananabrick March 20, 2023 17:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bananabrick)

This commit sets a new 30m timeout for all disk stall roachtests. Previously,
the FUSE filesystem variants had no timeout and inherited the default 10h
timeout. The other variants had a 20m timeout, which has been observed to be
too short due to upreplication latency.

Informs cockroachdb#98904.
Informs cockroachdb#98886.
Epic: None
Release note: None
@jbowens jbowens force-pushed the disk-stall-fuse-timeout branch from 0decec0 to 5f4fe6e Compare March 20, 2023 20:06
@jbowens jbowens changed the title roachtest: add timeout to fuse filesystem disk stall roachtests roachtest: set 30m timeout for all disk stall roachtests Mar 20, 2023
Copy link
Collaborator Author

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded the scope of this change to set the timeout to 30m to all disk-stall roachtests in light of #98904.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @bananabrick and @nicktrav)

Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @bananabrick)

@jbowens
Copy link
Collaborator Author

jbowens commented Mar 21, 2023

TFTR!

bors r=nicktrav

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Mar 21, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


Backport to branch 22.1.x failed. See errors above.


Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants