build: update restore regexp in roachtest AWS suite #99022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#98259, the concept of `Low` memory per vCPU was introduced in roachtest's `ClusterSpec`. That setting is currently only supported in GCE; if a test that uses that setting is run on any other cloud, roachtest will panic. The only roachtest using the low-memory setting is currently a restore test that is meant to run on GCE. However, the check for the appropriate cloud is done by that test during runtime (necessarily so), meaning a cluster will need to be created for the check to happen. By that point, the test runner will panic due to the unsupported memory setting. In the long term, we want to support ways for roachtests to indicate supported clouds outside the `Run` function (some context in cockroachdb#96655). For now, to stop a panic from happening in roachtest nightly runs on AWS, we update the regexp used to choose tests to run on AWS. We leverage the fact that `restore` tests include the cloud they are supposed to run in their name. Epic: none Release note: None
|
This change is |
msbutler
approved these changes
Mar 20, 2023
|
bors r=msbutler TFTR! |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #98259, the concept of
Lowmemory per vCPU was introduced in roachtest'sClusterSpec. That setting is currently only supported in GCE; if a test that uses that setting is run on any other cloud, roachtest will panic.The only roachtest using the low-memory setting is currently a restore test that is meant to run on GCE. However, the check for the appropriate cloud is done by that test during runtime (necessarily so), meaning a cluster will need to be created for the check to happen. By that point, the test runner will panic due to the unsupported memory setting.
In the long term, we want to support ways for roachtests to indicate supported clouds outside the
Runfunction (some context in #96655). For now, to stop a panic from happening in roachtest nightly runs on AWS, we update the regexp used to choose tests to run on AWS. We leverage the fact thatrestoretests include the cloud they are supposed to run in their name.Epic: none
Release note: None