ui: add badges for filter elements #98988
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dongniwang and @maryliag)
pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx line 814 at r1 (raw file):
const badges = Object.keys(filters).map(filter => { if ( filters[filter] != null &&
Not a big deal, but I see we do this check in calculateActiveFilters in the statements page as well, except it returns the number of active filters.
Maybe we could extend that to return the filters that are active, and in places that need the number we return the length?
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx line 814 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
Not a big deal, but I see we do this check in
calculateActiveFiltersin the statements page as well, except it returns the number of active filters.Maybe we could extend that to return the filters that are active, and in places that need the number we return the length?
Done
maryliag
force-pushed
the
filter-selection
branch
from
c2fae03 to
d82052c
Compare
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:
|
LGTM! Thanks for the quick turnaround! |
maryliag
force-pushed
the
filter-selection
branch
2 times, most recently
from
eeca861 to
9e9c89c
Compare
Adds badges for each of the selected filters on SQL Activity and Insights pages. Part Of cockroachdb#98891 Release note (ui change): Adds badges for each selected filter on SQL Activity and Insights pages.
maryliag
force-pushed
the
filter-selection
branch
from
9e9c89c to
81a866d
Compare
|
TFTR! |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Adds badges for each of the selected filters on SQL Activity and
Insights pages.
Part Of #98891
https://www.loom.com/share/e7417209fc704d71b2733f58609fb4de
Release note (ui change): Adds badges for each selected
filter on SQL Activity and Insights pages.