kvcoord: Add metric to keep track of restarted ranges in rangefeed #98980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
| @@ -653,6 +653,7 @@ func (ds *DistSender) singleRangeFeed( | |||
| // Ensure context is cancelled on all errors, to prevent gRPC stream leaks. | |||
| ctx, cancelFeed := context.WithCancel(ctx) | |||
| defer func() { | |||
| ds.metrics.RangefeedRestartRanges.Inc(1) | |||
There was a problem hiding this comment.
This is going to increment the metric when the rangefeed isn't restarted too, e.g. when cancelled.
There was a problem hiding this comment.
Added check on ctx.Err.
There was a problem hiding this comment.
It will also increment the metric when handleRangefeedError returns a permanent error. Shouldn't this be incremented in partialRangeFeed once we've actually determined to restart the rangefeed?
miretskiy
force-pushed
the
muxrf
branch
2 times, most recently
from
43abde5 to
7bc7b46
Compare
erikgrinaker
approved these changes
Mar 19, 2023
Add a `distsender.rangefeed.restart_ranges` metric to keep track of the number of ranges restarted due to transient error. Epic: CRDB-25044 Release note: None
|
bors r+ |
|
Build succeeded: |
This was referenced Apr 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
distsender.rangefeed.restart_rangesmetric to keep track of the number of ranges restarted due to transient error.Epic: CRDB-25044
Release note: None