Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: remove TestStoreMaxBehindNanosOnlyTracksEpochBasedLeases #98972

Merged

Conversation

erikgrinaker
Copy link
Contributor

This test attempts to assert something about expiration leases and closed timestamps that is no longer true: closed timestamps work just fine with expiration leases.

Resolves #98968.

Epic: none
Release note: None

@erikgrinaker erikgrinaker requested a review from a team March 19, 2023 10:55
@erikgrinaker erikgrinaker requested a review from a team as a code owner March 19, 2023 10:55
@erikgrinaker erikgrinaker self-assigned this Mar 19, 2023
This test attempts to assert something about expiration leases and
closed timestamps that is no longer true: closed timestamps work just
fine with expiration leases.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the remove-exp-lease-closedts-test branch from d672424 to ba2c2d7 Compare March 19, 2023 10:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 20, 2023

Build succeeded:

@craig craig bot merged commit 6839729 into cockroachdb:master Mar 20, 2023
@erikgrinaker erikgrinaker deleted the remove-exp-lease-closedts-test branch March 21, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv/kvserver: TestStoreMaxBehindNanosOnlyTracksEpochBasedLeases failed
3 participants