sql,backupccl: set system table user ID columns to be NOT NULL #98958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andyyang890
force-pushed
the
system_privileges_notnull
branch
4 times, most recently
from
b062dcf to
c59d196
Compare
andyyang890
changed the title
andyyang890
force-pushed
the
system_privileges_notnull
branch
13 times, most recently
from
4b82578 to
af43e9e
Compare
This patch adds the EmptyRole, which is used within some system tables. It also assigns this role the fixed ID of 0. Release note: None
Release note: None
This patch updates the `RESTORE` logic for the `system.privileges` table to handle restoring a backup that was created before the new `user_id` column was added. Release note: None
This patch updates the `RESTORE` logic for the `system.database_role_settings` table to handle restoring a backup that was created before the new `role_id` column was added. Release note: None
This patch updates the `RESTORE` logic for the `system.external_connections` table to handle restoring a backup that was created before the new `owner_id` column was added. Release note: None
andyyang890
force-pushed
the
system_privileges_notnull
branch
from
af43e9e to
649104b
Compare
Release note: None
This patch sets the user ID columns in system tables to be NOT NULL and when applicable, updates the migrations that added the columns. Release note: None
andyyang890
force-pushed
the
system_privileges_notnull
branch
from
649104b to
d3268f9
Compare
andyyang890
requested review from
rhu713,
rafiss,
stevendanna,
knz and
a team
and removed request for
a team
rafiss
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
thanks for breaking this down into small commits. it made it very easy to follow. lgtm!
could use a sign-off from the DR team as well.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @knz, @rhu713, and @stevendanna)
|
very nice, thank you 💯 |
|
TFTRs! bors r=rafiss,stevendanna |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the user ID columns in system tables to be NOT NULL
and when applicable, updates the
RESTORElogic to account forthe case where a backup may have been created before the user ID
column was added.
Part of #87079
Release note: None