Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfig: add TestBlockedKVSubscriberDisablesQueues #98807

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

irfansharif
Copy link
Contributor

Regression test for #98422 which disables {split,replicate,mvccGC} queues until subscribed to span configs. We're only slightly modifying the existing merge-queue specific TestBlockedKVSubscriberDisablesMerges.

Release note: None

@irfansharif irfansharif requested review from arulajmani and kvoli March 16, 2023 20:01
@irfansharif irfansharif requested a review from a team as a code owner March 16, 2023 20:01
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up. :lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @kvoli)

Regression test for cockroachdb#98422 which disables {split,replicate,mvccGC}
queues until subscribed to span configs. We're only slightly modifying
the existing merge-queue specific TestBlockedKVSubscriberDisablesMerges.

Release note: None
@irfansharif irfansharif force-pushed the 230316.spanconfig-queue-test branch from 4bd3f23 to e013c9c Compare March 21, 2023 14:48
@irfansharif
Copy link
Contributor Author

Just bouncing the license/cla checker.

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 21, 2023

Build succeeded:

@craig craig bot merged commit 18e6641 into cockroachdb:master Mar 21, 2023
@irfansharif irfansharif deleted the 230316.spanconfig-queue-test branch March 21, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants