release-22.2: spanconfig: export metrics for protected timestamp records #98796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #98540.
/cc @cockroachdb/release
This commit introduces two new metrics, to help understand the effects of protected timestamps:
spanconfig.kvsubscriber.protected_record_count
, which exports the number of protected timestamp records as seen by KV.spanconfig.kvsubscriber.oldest_protected_record_nanos
, which exports difference between the current time and the oldest protected timestamp. Sudden drops indicate a record being released; an ever-increasing duration would indicate the oldest record sticking around and preventing GC if > the configured GC TTL.Fixes #98532 (as a backportable alternative to a0d6c19 for 22.1, 22.2).
Release note: None
Release justification: Adds helpful metrics that would've come in handy in internal escalations