Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: spanconfig: export metrics for protected timestamp records #98796

Merged

Conversation

irfansharif
Copy link
Contributor

@irfansharif irfansharif commented Mar 16, 2023

Backport 1/1 commits from #98540.

/cc @cockroachdb/release


This commit introduces two new metrics, to help understand the effects of protected timestamps:

  • spanconfig.kvsubscriber.protected_record_count, which exports the number of protected timestamp records as seen by KV.
  • spanconfig.kvsubscriber.oldest_protected_record_nanos, which exports difference between the current time and the oldest protected timestamp. Sudden drops indicate a record being released; an ever-increasing duration would indicate the oldest record sticking around and preventing GC if > the configured GC TTL.

Fixes #98532 (as a backportable alternative to a0d6c19 for 22.1, 22.2).

Release note: None
Release justification: Adds helpful metrics that would've come in handy in internal escalations

@irfansharif irfansharif requested review from arulajmani, adityamaru, miretskiy and a team March 16, 2023 18:22
@irfansharif irfansharif requested a review from a team as a code owner March 16, 2023 18:22
@blathers-crl
Copy link

blathers-crl bot commented Mar 16, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit introduces two new metrics, to help understand the effects
of protected timestamps:
- spanconfig.kvsubscriber.protected_record_count, which exports the
  number of protected timestamp records as seen by KV.
- spanconfig.kvsubscriber.oldest_protected_record_nanos, which exports
  difference between the current time and the oldest protected
  timestamp. Sudden drops indicate a record being released; an
  ever-increasing duration would indicate the oldest record sticking
  around and preventing GC if > the configured GC TTL.

Fixes cockroachdb#98532 (as a backportable alternative to
a0d6c19 for 22.1, 22.2).

Release note: None
@irfansharif irfansharif merged commit fd258fa into cockroachdb:release-22.2 Mar 21, 2023
@irfansharif irfansharif deleted the backport22.2-98540 branch March 21, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants