-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: enable kv/gracefuldraining/nodes=3 #98720
Conversation
I'm confused why you switched from the admin ts stats to Prometheus stats. I was hoping with https://grafana.testeng.crdb.io/ set up, we could stop launching separate Prometheus instances with each test, but this change makes that harder to do. |
fb790c8
to
96745fb
Compare
Discussed offline. I updated this commit just to re-enable the test. I was originally very suspicious of the internal timeseries metrics possibly running into an erroneous windowing issue, which could be dealt with separately. However, upon double checking the debug stuff I had, I realized the drop in QPS was legitimate and showed up in the workload runner (I looked at a different run initially). I think we should re-enable the test as is. It has already produced useful findings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - We might have to disable again, but we will at least get a chance to see if things are better.
This commit re-enables the `kv/gracefuldraining/nodes=3` roachtest. The test is still likely to fail occasionally however has produced interesting findings just in testing to re-enable. Informs: cockroachdb#59094 Release note: None
96745fb
to
d0120ff
Compare
@andrewbaptist do you think now's a good time to re-enable? It will likely flake in a couple/few weeks but could also find interesting regressions. |
Going to re-enable this now, I'm anticipating some possible failures in the future but it will be good to start getting coverage again. bors r=andrewbaptist |
Build succeeded: |
This commit re-enables the
kv/gracefuldraining/nodes=3
roachtest. Thetest is still likely to fail occasionally however has produced
interesting findings just in testing to re-enable.
Informs: #59094
Release note: None