sql: make sure mixed version logic tests are enabled for declarative schema changer enabled DDL in 22.2 #98697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
fqazi
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 10 of 10 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan)
-- commits line 7 at r2:
Nit: this is for both mixed and non-mixed
Release note: None.
Release note: None
chengxiong-ruan
force-pushed
the
make-sure-mixed-version-logic-test
branch
from
c42221f to
033951f
Compare
|
TFTR! |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs: #98637
This PR makes sure we enable mixed version logic tests for ddl statements enabled in declarative schema changer in 22.2.
We already have mixed version test coverage for
CREATE INDEX,DROP INDEX,ADD COLUMN,DROP COLUMNandADD CONSTRAINT.Each commit turns on mixed version logic test for each of
DROP OWNED BY,COMMENT ONandALTER PRIMARY KEY.