bazel: add dev test-binaries command #98599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add command roachprod-bench-wrapper to dev. The command will build all the test binaries for a given set of packages, using Bazel. Any runfiles required by the binaries will also be staged. Binaries and runfiles are added to a tar in artifacts and can be optionally compressed. The output is portable without being dependent on the repository. Each package is supplied with a run script that will set up environment variables for Bazel runfiles to be used by the test binary. Additionally, this builds the binary for a sub command roachprod-bench that will orchestrate the execution of the binaries. The sub command is also executed by the roachprod-bench command with specified arguments passed to it. Resolves: cockroachdb#90837 See also: cockroachdb#90958 Epic: CRDB-20903 Release justification: test-only change. Release note: None
This intends to decouple generating test binaries and running the roachprod microbenchmarks command. Rather than having a strong coupling this command will now just build and archive the portable test binaries that can then be used by any other commands in the future. The command also no longer builds the libraries or the roachprod microbenchmarks binary (formerly roachprod-bench). After this change `dev test-binaries` will only generate an archive of portable test binaries. This archive can then be used with the roachprod microbenchmarks command, possibly amongst other things, to run microbenchmarks. See also: cockroachdb#90958 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
smg260
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 3 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @herkolategan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command roachprod-bench-wrapper to dev. The command will build all the test
binaries for a given set of packages, using Bazel. Any runfiles required by the
binaries will also be staged. Binaries and runfiles are added to a tar in
artifacts and can be optionally compressed. The output is portable without being
dependent on the repository.
Each package is supplied with a run script that will set up environment variables
for Bazel runfiles to be used by the test binary.
Additionally, this builds the binary for a sub command roachprod-bench that will
orchestrate the execution of the binaries. The sub command is also executed by
the roachprod-bench command with specified arguments passed to it.
Resolves: #90837
See also: #90958
Epic: CRDB-20903
Release justification: test-only change.
Release note: NoneBackport:
Please see individual PRs for details.
/cc @cockroachdb/release