-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allocator: fix lease io enforcement setting typo #98543
Conversation
This commit updates the "do nothing" lease IO overload enforcement (`kv.allocator.lease_io_overload_threshold_enforcement`) setting to be correctly spelled "ignore" rather than "ingore". Part of: cockroachdb#96508 Release note (ops change): The `kv.allocator.lease_io_overload_threshold_enforcement` setting value which disables enforcement is updated to be spelled correctly as "ignore" rather than "ingore".
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r=andrewbaptist |
Build succeeded: |
@kvoli We're going to include 'key cluster setting changes to review' in the 23.1 GA Release Notes. I assume users do not need to worry about this if they're using the default value, but what if they've set a custom value? Will they be impacted if they don't set the value under the new name before upgrading, or is this handled automatically? Anything else to consider from a customer-impact perspective? |
For this change - the cluster setting was addhoed in 23.1. Users shouldn't have any value for this setting. Are you referring to |
@kvoli Thank you. I was referring to the former. Will exclude. As for |
This commit updates the "do nothing" lease IO overload enforcement (
kv.allocator.lease_io_overload_threshold_enforcement
) setting to be correctly spelled "ignore" rather than "ingore".Part of: #96508
Release note (ops change): The
kv.allocator.lease_io_overload_threshold_enforcement
setting value which disables enforcement is updated to be spelled correctly as "ignore" rather than "ingore".