Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocator: fix lease io enforcement setting typo #98543

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Mar 13, 2023

This commit updates the "do nothing" lease IO overload enforcement (kv.allocator.lease_io_overload_threshold_enforcement) setting to be correctly spelled "ignore" rather than "ingore".

Part of: #96508

Release note (ops change): The
kv.allocator.lease_io_overload_threshold_enforcement setting value which disables enforcement is updated to be spelled correctly as "ignore" rather than "ingore".

This commit updates the "do nothing" lease IO overload enforcement
(`kv.allocator.lease_io_overload_threshold_enforcement`)
setting to be correctly spelled "ignore" rather than "ingore".

Part of: cockroachdb#96508

Release note (ops change): The
`kv.allocator.lease_io_overload_threshold_enforcement` setting value
which disables enforcement is updated to be spelled
correctly as "ignore" rather than "ingore".
@kvoli kvoli self-assigned this Mar 13, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 13, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli marked this pull request as ready for review March 13, 2023 22:06
@kvoli kvoli requested a review from a team as a code owner March 13, 2023 22:06
@kvoli kvoli requested a review from andrewbaptist March 13, 2023 22:06
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvoli
Copy link
Collaborator Author

kvoli commented Mar 14, 2023

bors r=andrewbaptist

@craig
Copy link
Contributor

craig bot commented Mar 14, 2023

Build succeeded:

@mikeCRL
Copy link
Contributor

mikeCRL commented May 10, 2023

@kvoli We're going to include 'key cluster setting changes to review' in the 23.1 GA Release Notes. I assume users do not need to worry about this if they're using the default value, but what if they've set a custom value? Will they be impacted if they don't set the value under the new name before upgrading, or is this handled automatically? Anything else to consider from a customer-impact perspective?

@kvoli
Copy link
Collaborator Author

kvoli commented May 10, 2023

For this change - the cluster setting was addhoed in 23.1. Users shouldn't have any value for this setting.

Are you referring to kv.allocator.replica_io_overload_threshold_enforcement? Users do need to update to a new setting if they were not using the default in 22.2.

@mikeCRL
Copy link
Contributor

mikeCRL commented May 12, 2023

@kvoli Thank you. I was referring to the former. Will exclude.

As for kv.allocator.replica_io_overload_threshold_enforcement - I believe it's not a public setting so we don't have to worry about it here. Please let me know if you disagree. CC @shannonbradshaw who was looking at settings with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants