requestbatcher: deflake TestBatchTimeout #98512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#97832. This commit deflakes `TestBatchTimeout/WithTimeoutAndPagination`. The test was setting an aggressive MaxTimeout and then not handling all cases where the timeout could fire. Luckily, the test did not ever actually want the timeout to fire, so we can deflake it by simply setting a large (but non-zero) MaxTimeout. This still allows us to assert that time timeout is applied across all sub-batches in a paginated request. Release note: None
|
This change is |
arulajmani
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97832.
This commit deflakes
TestBatchTimeout/WithTimeoutAndPagination. The test was setting an aggressive MaxTimeout and then not handling all cases where the timeout could fire. Luckily, the test did not ever actually want the timeout to fire, so we can deflake it by simply setting a large (but non-zero) MaxTimeout. This still allows us to assert that time timeout is applied across all sub-batches in a paginated request.Release note: None