Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: unskip TestExecBuild_sql_activity_stats_compaction #98509

Conversation

ericharmeling
Copy link
Contributor

@ericharmeling ericharmeling commented Mar 13, 2023

This commit unskips TestExecBuild_sql_activity_stats_compaction in local configuration.

0 failures after 15000+ runs

Fixes #91600.

Epic: none

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling ericharmeling force-pushed the unskip-execbuilder-sql_activity_stats_compaction branch 5 times, most recently from 1253b72 to bbf7841 Compare March 13, 2023 22:23
This commit fixes and unskips
TestExecBuild_sql_activity_stats_compaction in the local
configuration, with updated testdata.

Fixes cockroachdb#91600.

Epic: none

Release note: None
@ericharmeling ericharmeling force-pushed the unskip-execbuilder-sql_activity_stats_compaction branch from bbf7841 to f1400d5 Compare March 29, 2023 18:44
@ericharmeling ericharmeling requested a review from a team March 29, 2023 22:04
@ericharmeling ericharmeling marked this pull request as ready for review March 29, 2023 22:04
@ericharmeling ericharmeling requested a review from a team as a code owner March 29, 2023 22:04
@ericharmeling ericharmeling requested a review from michae2 March 29, 2023 22:04
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

@ericharmeling
Copy link
Contributor Author

TFTR!

@ericharmeling
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 30, 2023

Build succeeded:

@craig craig bot merged commit 476cd85 into cockroachdb:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execbuilder: add deterministic test for stats compaction DELETE queries
3 participants