Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgradejob: initialize the kvdb on TenantDeps #98489

Conversation

jeffswenson
Copy link
Collaborator

The KVDB field was created as part of PR #93218, but it was never initialized.

Part of #94843

Release Note: None

The KVDB field was created as part of PR cockroachdb#93218, but it was never
initialized.

Part of cockroachdb#94843

Release Note: None
@jeffswenson jeffswenson requested review from ajwerner and a team March 13, 2023 13:26
@blathers-crl
Copy link

blathers-crl bot commented Mar 13, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jeffswenson
Copy link
Collaborator Author

This change is cherry-picked into the following PRs:
#98445
#98446
#98463

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeffswenson
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 13, 2023

Build succeeded:

@craig craig bot merged commit 9ed78bf into cockroachdb:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants